[trunk] name errors found by pylint
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Odoo Server (MOVED TO GITHUB) |
Confirmed
|
Medium
|
OpenERP's Framework R&D |
Bug Description
Hello,
I ran pylint on the trunk server code, and it found a few bugs (I've doubled checked them for false positives, and these seem genuine, unless openerp is doing weird things with the namespaces under the cover):
************* Module openerp.
E0602:423,
************* Module openerp.
E0602:323,
************* Module openerp.
E0602: 41,19:base_
************* Module openerp.
E0602: 41,18:ir_
E0602: 41,29:ir_
E0602: 41,54:ir_
************* Module openerp.
E0602: 33,18:ir_
E0602: 33,29:ir_
E0602: 33,54:ir_
The following one is probably a false positive, but I'm awkward in relying in a variable leaking from a genexp. Also in this code, you don't provide the user with the full list of modules which cannot be uninstalled because of the presence of module data, which means that the user will have to unselect them one by one, which makes for poor user XP, so it probably deserves being rewritten by filling up a list with models matching the faulty condition.
************* Module openerp.
E0602:158,
The last one is a requirement for a cleanup of an outdated if __name__ == "__main__" section:
************* Module openerp.
E0602:127,27: Undefined variable 'int_to_text'
E0602:129,27: Undefined variable 'int_to_text'
E0602:131,14: Undefined variable 'int_to_text'
For the record the command line that I used is:
PYTHONPATH=
Changed in openobject-server: | |
assignee: | nobody → OpenERP's Framework R&D (openerp-dev-framework) |
importance: | Undecided → Medium |
status: | New → Confirmed |
I suspect that some of these may also be present in stable, esp. the ones in openerp.report. It can't hurt to double check.