wrong undeductible tax

[Antonio M. - Zeroincombenze]

Randomly, software report follow wrong error message:
"The taxes %s have different rates"
As in example file, undeductible tax has 2 sub codes, first with suffix a for undeductible rate and last with suffix b for deductible rate.
The last one has type = 'balance' in order to receive all residual amount.

The wrong code at line 35, property '_have_same_rate' does not check for this condition and returns a unpredictable value, as is randomly recorded.

Suggested correction:
<code>
  for account_tax in account_taxes: # <- Code un changed
      if account_tax.type != 'balance': # Check for balance type
          if rate is None: # <- code unchanged
</code>

[Lorenzo Battistini (elbati)]

Ciao Antonio,
in order to confirm the bug, we need the steps to reproduce it.
Thanks

[Antonio M. - Zeroincombenze (zeroincombenze)]

Ciao Lorenzo,
siccome ho poca dimestichezza con Launchpad ti chiedo un chiarimento:
se ho compreso bene, le mail che mio sono arrivate indicano che avete
accettato il merge in openobject-italia;
non mi è chiaro il significato/Status in //OpenERP Italia: Incomplete/
nel primo messaggio sotto riportato.

Immagino siano messaggi tecnici di Launchpad ma vorrei capire un po' di
più slu flusso di infomazioni di Launchpad.

Grazie

Antonio M. Vigliotti

[Bug 1335867] Re: wrong undeductible tax
Oggetto: [Bug 1335867] Re: wrong undeductible tax
Mittente: Lorenzo Battistini - Agile BG <email address hidden>
Data: 03/07/2014 08:27

A: <email address hidden>

** Branch linked: lp:~zeroincombenze/openobject-italia/7.0

-- You received this bug notification because you are subscribed to the
bug report. https://bugs.launchpad.net/bugs/1335867 Title: wrong
undeductible tax Status in OpenERP Italia: Incomplete Bug description:
Randomly, software report follow wrong error message: "The taxes %s have
different rates" As in example file, undeductible tax has 2 sub codes,
first with suffix a for undeductible rate and last with suffix b for
deductible rate. The last one has type = 'balance' in order to receive
all residual amount. The wrong code at line 35, property
'_have_same_rate' does not check for this condition and returns a
unpredictable value, as is randomly recorded. Suggested correction:
<code> for account_tax in account_taxes: # <- Code un changed if
account_tax.type != 'balance': # Check for balance type if rate is None:
# <- code unchanged </code> To manage notifications about this bug go
to:
https://bugs.launchpad.net/openobject-italia/+bug/1335867/+subscriptions

[Leonardo Pistone (lepistone)]

Hi.

The bug and the merge proposal have each one their own status. The bug here has been set to incomplete by Lorenzo.

The merge proposal has two positive votes by Davide and Lorenzo and has not been merged yet. So it usually needs a third approval and someone to actually do the merge.

[Antonio M. - Zeroincombenze (zeroincombenze)]

Il 03/07/2014 09:40, Leonardo Pistone - camptocamp ha scritto:
> Hi.
>
> The bug and the merge proposal have each one their own status. The bug
> here has been set to incomplete by Lorenzo.
>
> The merge proposal has two positive votes by Davide and Lorenzo and has
> not been merged yet. So it usually needs a third approval and someone to
> actually do the merge.
>
Thx for clear exposition!

--

Antonio M. Vigliotti
(Presidente & Chief Technical Officer)

*SHS-AV s.r.l. (impresa innovativa)
zeroincombenze®
*

Via Domodossola, 64 - 10145 TORINO - ITALY

Tel. [phone](2)

www.shs-av.com

PEC <email address hidden>

[Launchpad Janitor (janitor)]

[Expired for OpenERP Italia because there has been no activity for 60 days.]

[Marco Di Francesco (marco-difra)]

I am out of the office from Wed 20/08/2014 until Mon 12/01/2015.

I will respond to your message when I return.

Note: This is an automated response to your message "[Bug 1335867] Re:
wrong undeductible tax" sent on 02/09/2014 6.17.31.

This is the only notification you will receive while this person is away.