Impossibile duplicare stock.picking

[Davide Corio]

Provando a duplicare un DDT (stock.picking) dopo aver installato l10n_it_sale, si ottiene questo errore:

File "/Users/enlightx/Development/OpenERP/7.0/dev/parts/openobject-italia/l10n_it_sale/stock/picking.py", line 89, in copy
    default.update({'ddt_number': ''})
TypeError: super(type, obj): obj must be an instance or subtype of type

[Leonardo Pistone (lepistone)]

Davide,

while fixing that, I suggest also using using

def copy(... default=None ... )
    if default is None:
        default = {}

the same way we do for the context (and for the same reasons).

Thanks!

[Davide Corio (enlightx-deactivatedaccount)]

sure! thanks for the suggestion

[Davide Corio (enlightx-deactivatedaccount)]

well, actually the signature of that method is:

(self, cr, uid, id, default={}, context=None)

then default couldn't be None

am i wrong?

[Leonardo Pistone (lepistone)]

Except very special cases, it's better to avoid all mutable default values. In our base, both context and default. See for example:

http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/view/head:/mrp/product.py#L31

and

http://bazaar.launchpad.net/~openerp/openobject-server/7.0/view/head:/openerp/osv/orm.py#L5051

[Davide Corio (enlightx-deactivatedaccount)]

ok! gonna change that. thanks again