spinbutton scroll changes prices and quantities
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Odoo GTK Client (MOVED TO GITHUB) |
Fix Committed
|
Undecided
|
Numérigraphe |
Bug Description
Scrolling on GTK/QT spinbuttons changes value. But it's too much dangerous to change prices and quantities on the fly. Even if we confirm changes on popup, we may not have seen all changes we confirm.
As far as I know, we can't disable scrolling on spinbuttons, but we can set step increment to 0 instead of one.
I propose to change those lines:
./widget/
./widget/
into:
./widget/
./widget/
Thanks for applying changes or returning a feed-back.
Related branches
- OpenERP Core Team: Pending requested
-
Diff: 52 lines (+7/-2)3 files modifiedbin/options.py (+1/-0)
bin/widget/view/form_gtk/spinbutton.py (+3/-1)
bin/widget/view/form_gtk/spinint.py (+3/-1)
- OpenERP Core Team: Pending requested
-
Diff: 52 lines (+7/-2)3 files modifiedbin/options.py (+1/-0)
bin/widget/view/form_gtk/spinbutton.py (+3/-1)
bin/widget/view/form_gtk/spinint.py (+3/-1)
- OpenERP sa GTK client R&D: Pending requested
-
Diff: 52 lines (+7/-2)3 files modifiedbin/options.py (+1/-0)
bin/widget/view/form_gtk/spinbutton.py (+3/-1)
bin/widget/view/form_gtk/spinint.py (+3/-1)
security vulnerability: | yes → no |
visibility: | private → public |
Hello Frédéric,
Thank you for the proposed patch, however it looks like this would disable the mousewheel as well as the up/down buttons on all integer/float fields, which could be quite annoying and make them harder to use.
I suppose it makes sense to use a locally patched client if your users tend to use the mousewheel when focused on int/float fields.
Maybe for the future we could think of a way to selectively turn this feature on/off. Alternatively you could consider switching the sensitive fields to a different widget, if you only have a few.
I hope you understand our point of view...