Field / button 'attrs' not evaluated correctly with multiple conditions [FIX PROVIDED]

[Russell Briggs]

I have the following button in my form:

<button name="button_completed" string="Completed" type="object" icon="gtk-index"
  attrs="{'invisible':['|',('order_type','not in',['sample','stock']),('state','!=','new')]}" />

The attrs is designed to show the button only for orders of type 'sample' and 'stock', with a status of 'new', however only the first part of the condition (order_type) was being evaluated correctly.

I tracked this down to a tiny javascript error in 'form_evalExpr' function in form_state.js. As it loops through each condition, it does not reset the value of 'elem' to null, so it simply reuses the first element for each of the subsequent evaluations.

Fix attached.

[filsys (office-filsystem)]

I have tested your patch with a many2one filed:

<field name="prodlot_id"
domain="[('product_id','=',product_id),('stock_available','&gt;',0)]"
attrs="{'invisible':
['|',('prodlot_id','&lt;&gt;',False),('tracking','=',False)]}"/>

Did not work.

Pe 14.02.2011 20:52, Russell Briggs a scris:
> ** Patch added: "fix_attrs_eval.patch"
> https://bugs.launchpad.net/bugs/718925/+attachment/1849826/+files/fix_attrs_eval.patch
>

[Russell Briggs (russell-briggs)]

Have you checked the conditions work correctly individually? I would try adding some alert or console.log statements to the 'form_evalExpr' function then you will be able to see the results of the evaluations

[DBR (OpenERP) (dbr-openerp)]

Hello Russell Briggs,

I have checked "attrs" of multi condition with Button and field at our end
But did not face any problem.
Would you please provide us related proper example?
So, It will be more helpful to reproduce and qualify bug.

Thank you.

[Launchpad Janitor (janitor)]

[Expired for OpenERP Web Client because there has been no activity for 60 days.]

[DBR (OpenERP) (dbr-openerp)]

Hello,

I have check the " attrs " again with latest stable code.
It is working fine .So, For now I am closing this bug.
If you still face the same problem again you can reopen this bug.
I have attached a video for your reference.

Thanks.