Accuracy of float values doesn't match price_accuracy

[nrumprecht]

It's more a problem than a bug,
but if you configure openerp to have a price accuracy of 4 and you have prices for your products
like 12.4432 € and add this product to a sale order line, the price that i get through the onchange method
is rounded by the openerp web client, by the class float in openerp/validators/validator.py (digit = 2) to 12.44 €,
and that is the price added to the sale_order_line like 12.4400 €. So you cannot work with the web-client if
you've another price accuracy than 2 in the openerp web server. The digit value should be set by a config file,
or better be requestet from openerp server price_accuracy value.

Greets,

Nils Rumprecht

[Ferdinand (office-chricar)]

I am working on a solution for price unit here
this allows to define arbitrtry price units while retaining the default decimal digits for accountig purpose
https://code.launchpad.net/~openerp-commiter/openobject-addons/chricar_price_unit

[Navrang Oza (noz-tiny)]

Hello,

In Web-client also its working fine.
You can check by using price_accuracy parameter at server side.

But for sale order line, there are some minor changes required to solve your problem.
Here attached screenshot may help you.

Thanks.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Fixed by revision 2574 <email address hidden>.
Thanks.

[Omar (Pexego) (omar7r)]

Hi,

Review the first post, this error it shows too in purchase.order.line, when in web client product_id_change is fired, when i select a product, it sets price_unit field to for example 1,1213 because i has price_accuracy 5, but in web client when try to show the result it shows the value rounded to 2 digits because as in the first post was said in class Float of web client is defined digit=2 as constant, then the function calls format.format_decimal(float(value) or 0.0, self.digit) and executes inside:
 v = ("%%.%df" % digits) % value. Then always in on_change event with floats will show 2 decimals. In gtk it works fine.

Thanks.

[Sananaz (Open ERP) (sma-tiny)]

Hello,

Its fixed in stable. Please update your code and notify us.

Revision-info:
2838 <email address hidden>

Thanks.

[Omar (Pexego) (omar7r)]

Hi sma,

It isn't fix. Where you write your lines, obtain the digits but the float was rounded yet to two digits then if it maintains the digits it's good but the number it's not the original. On Float() class, validators.py file inside _from_python() function it did the rounding. I think that bug it is here.

Other thing is that in Spain or other counties where float symbol is the comma not point, your lines fail, you can write for example:
values[k] = format.format_decimal(float(values[k].replace(',', '.')) or 0.0, digit or 2)

Thanks

[Sananaz (Open ERP) (sma-tiny)]

Hello,

Its fixed by 2839 <email address hidden>

Thanks.

[Sananaz (Open ERP) (sma-tiny)]

Hello omar,

You are right, it cant work if other countries where float symbol is the comma not point.
Now fixed that problem in stable. Please update your code and notify us.

Revision-info:
2841 <email address hidden>

Thanks for pointing out.