[trunk, 6.1, 6.0] [account] [wizard account.invoice.refund] Invoice refund wizard make error with other relational fields

Bug #896462 reported by Moisés López - http://www.vauxoo.com
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Status tracked in Trunk
6.0
Won't Fix
Low
OpenERP Publisher's Warranty Team
7.0
New
Undecided
OpenERP Publisher's Warranty Team
Trunk
New
Low
OpenERP R&D Addons Team 3

Bug Description

1) Steps to reproduce the issue you have observed:
   Add a new many2one field to account.invoice.line model.
   Create a new invoice
   Press button refund to invoke account.invoice.refund from invoice
   Confirm operation
2) The result you observed
    Error with new field many2one.
3) The result you expected
    Create a new refund invoice
4) The platform your are using
    OpenERP-6 & OpenERP-Trunk
5) OpenERP-6 revno 4934
     OpenERP-Trunk revno 5791

This bug is result of a Hard-Code in function:
account/account_invoice.py -> class account_invoice -> def _refund_cleanup_lines
The relational fields is assing with the name of current fields (hard-code), but this not compatible with new functionallity and inherit.

I will create a proposal merge with the issue

Tags: maintenance

Related branches

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Low
status: New → Confirmed
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
DJ Patel (OpenERP) (mdi-openerp) wrote :

Hello Moisés López,

Thanks for reporting. The solution for this bug is proposed in the branch : https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-896462-mdi/

with following Revision ID and Number.

Revision ID : <email address hidden>
Revision Number : 5843

Thanks and Regards,

Divyesh Makwana(MDI)

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :

Hello Divyesh Makwana

I tested it Done!

Greats

Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :

Hello,
Excuse me

What is the state of this issue?

Changed in openobject-addons:
status: Fix Committed → Confirmed
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
DJ Patel (OpenERP) (mdi-openerp) wrote :

Hello Moisés López,

Thanks for reporting. The solution for this bug is proposed in the branch : https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-896462-mdi/

with following Revision ID and Number.

Revision ID : <email address hidden>
Revision Number :5847

Thanks,
Divyesh

Changed in openobject-addons:
status: In Progress → Fix Committed
tags: added: maintenance
summary: - [trunk & 6.0] [account] [wizard account.invoice.refund] Invoice refund
- wizard make error with other relational fields
+ [trunk, 6.1, 6.0] [account] [wizard account.invoice.refund] Invoice
+ refund wizard make error with other relational fields
Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :

Hello Somesh,
You will need try it with data in new field.
If field is empty no error.
If field has data show error

I tested the merge proposal of Divyesh Makwana
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-896462-mdi
And this fix is fine.

Just we need this merge in OpenERP-6.1 and OpenERP-6.0

Regards

Revision history for this message
Somesh Khare (somesh.khare) wrote :

Hello Moy lop,

With reference to your maintenance Ticket, As we have discussed with our experts and came to a conclusion that we can not make such a major changes into the stable series because It may create regression on the systems those are already in production, specially those who are using the account related module.

As a fix has already proposed for the trunk version and once approved will be available with the next OpenERP version, So for stable we keep the status of this bug as Won't fix.

Thanks for your understanding.

Regards,
Somesh Khare

Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :

Hello Somesh
I understand, thank you.

Now, we have a the same problem with new version 7.0 & trunk

Revision history for this message
Nhomar - Vauxoo (nhomar) wrote :

Hello.

Again the video, please this is a big problem, because is silently passing:

http://www.youtube.com/watch?v=EmWcnFSk6fk&sns=em

In our OPW contract they dont want to merge (even already merged in 6.1) and they forgot merge to 7.0, IMHO it must be merged.

Regards.

Revision history for this message
Moisés López - http://www.vauxoo.com (moylop260) wrote :

I add the Somesh's conversation:
...so that our R & D team will find a more clean fix for the trunk version with reference to the lp:~openerp-dev/openobject-addons/trunk-bug-896462-mdi branch because it required lots of changes which is against the stable bug policy...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.