[6.1] [mrp] Translate string uses concatenation instead of modifier resulting in incorrect stock move name

Bug #938251 reported by Graeme Gellatly
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Status tracked in Trunk
6.1
Fix Committed
Undecided
OpenERP Publisher's Warranty Team
Trunk
Fix Released
Low
OpenERP R&D Addons Team 2

Bug Description

@@ -926,7 +926,7 @@
         stock_move = self.pool.get('stock.move')
         source_location_id = production.product_id.product_tmpl_id.property_stock_production.id
         destination_location_id = production.location_dest_id.id
- move_name = _('PROD: %s') + production.name
+ move_name = _('PROD: %s') % production.name
         data = {
             'name': move_name,
             'date': production.date_planned,

File is mrp.py - sorry didn't post patch as I've had to make quite a lot of changes already to that file but is simple enough.

Related branches

Changed in openobject-addons:
status: New → Incomplete
status: Incomplete → Confirmed
importance: Undecided → Low
assignee: nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
Revision history for this message
Ravish(OpenERP) (rmu-openerp) wrote :

Hello,

I have checked with using % . It is printing PROD: MO/00016(just for example) instead of PROD: %sMO/00015.
So I am assign it to responsible team.

Thanks!!

Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Mayur Maheshwari(OpenERP) (mma-openerp) wrote :

Hello Graeme Gellatly,

Thanks for your contribution .
It has been fixed in lp:~openerp-dev/openobject-addons/trunk-bug-938251-mma With
Revision ID: <email address hidden>
Revision num: 6668

It will be available in trunk soon.

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Kirti Savalia(OpenERP) (ksa-openerp) wrote :

Hello,

It has been fixed in http://bazaar.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-579756-ksa With
Revision-id: <email address hidden>
Revno: 7007

It will be available in stable soon.

Thanks

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

Hello,

I see the bug was fixed on trunk (great) but the merge proposal was rejected on stable ? Why ? It is 0-risk, and while the bug is not harmful, it gives a bad impression to end users.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.