OpenERP Addons (modules)

Activity log for bug #532148

Date Who What changed Old value New value Message
2010-03-04 20:08:04 Don Kirkby bug added bug
2010-03-04 20:23:57 Don Kirkby branch linked lp:~donkirkby/openobject-addons/complete-procurement
2010-03-05 05:40:24 gpa(OpenERP) openobject-addons: status New Incomplete
2010-03-05 18:38:54 Don Kirkby description I am testing with the 5.0 branch of openobject-addons revision 2582. I will attach a merge proposal with a failing unit test, but here are the steps to reproduce the problem using the demo data: - Create a procurement for 3 units of MB1. - Confirm the procurement. - Run the procurement. - Open the purchase order that it generated. - Confirm the purchase order. - Approve the purchase order. - Open the incoming shipment that it generated. - Receive the shipment. Expected behaviour: At this point, I would expect the procurement to be done. Actual behaviour: The procurement is still in the ready state. Running the scheduler makes no change. If you open the stock move associated with the procurement and mark it as done, then the procurement is done. You might need to run the scheduler first, I can't remember. Analysis: The procurement work flow transition from ready to done requires action_check_finnished() to succeed. That checks that the stock move is complete. I happened to notice that action_done() will mark the stock move as complete if the close_move field is true, but action_done won't trigger until the procurement gets to the done state. Catch-22. Perhaps there's some other code that is supposed to mark the stock move as complete, but the close_move field seems like it would never be useful. I am testing with the 5.0 branch of openobject-addons revision 2582. I will attach a merge proposal with a failing unit test, but here are the steps to reproduce the problem: - Create a new database with demo data. - Choose the Manufacturing Industry profile, but leave all the other configuration with the defaults. - Create a procurement for 3 units of MB1 at location Stock. - Confirm the procurement. - Run the procurement. - Open the purchase order that it generated. - Confirm the purchase order. - Approve the purchase order. - Open the incoming shipment that it generated. - Receive the shipment. Expected behaviour: At this point, I would expect the procurement to be done. Actual behaviour: The procurement is still in the ready state. Running the scheduler makes no change. If you open the stock move associated with the procurement and mark it as done, then the procurement is done. You might need to run the scheduler first, I can't remember. Analysis: The procurement work flow transition from ready to done requires action_check_finnished() to succeed. That checks that the stock move is complete. I happened to notice that action_done() will mark the stock move as complete if the close_move field is true, but action_done won't trigger until the procurement gets to the done state. Catch-22. Perhaps there's some other code that is supposed to mark the stock move as complete, but the close_move field seems like it would never be useful.
2010-03-05 18:47:21 Don Kirkby attachment added Screen shot of procurement stuck in ready state http://launchpadlibrarian.net/40268700/ProcurementReady.png
2010-03-05 19:11:39 Don Kirkby openobject-addons: status Incomplete New
2010-03-08 11:52:26 Jay Vora (Serpent Consulting Services) openobject-addons: assignee Olivier Dony (OpenERP) (odo)
2010-12-21 12:37:51 DBR (OpenERP) openobject-addons: importance Undecided Low
2010-12-21 12:37:51 DBR (OpenERP) openobject-addons: status New Confirmed
2011-08-29 06:37:03 MarianTheisen bug added subscriber MarianTheisen
2011-08-31 11:31:15 Joël Grand-Guillaume @ camptocamp openobject-addons: importance Low High
2011-08-31 12:36:59 Quentin THEURET @TeMPO Consulting bug added subscriber Quentin THEURET
2011-08-31 13:48:02 snook bug added subscriber snook
2011-08-31 14:12:22 claude dunnigan bug added subscriber claude dunnigan
2011-08-31 18:04:43 Olivier Dony (OpenERP) openobject-addons: importance High Undecided
2011-08-31 18:04:43 Olivier Dony (OpenERP) openobject-addons: status Confirmed Fix Released
2011-08-31 18:04:43 Olivier Dony (OpenERP) openobject-addons: assignee Olivier Dony (OpenERP) (odo)
2011-08-31 18:05:10 Olivier Dony (OpenERP) nominated for series openobject-addons/5.0
2011-08-31 18:05:10 Olivier Dony (OpenERP) bug task added openobject-addons/5.0
2011-08-31 18:05:55 Olivier Dony (OpenERP) openobject-addons/5.0: importance Undecided High
2011-08-31 18:05:55 Olivier Dony (OpenERP) openobject-addons/5.0: status New Incomplete
2011-09-01 19:02:03 Davide Corio @ LS bug added subscriber Davide Corio - agilebg.com