[trunk / 6.1] sale order line th_weight is not correct

[Nicolas Bessi - Camptocamp]

There is a little error in sale order line th_weight it is not computed correctly with qty > 1
It seems that a parenthesis is missing. But is also dot not take in account SoLine UOS but and use product coef.
The FixME should be Fixed

=== modified file 'sale/sale.py'
--- sale/sale.py 2012-02-16 16:52:53 +0000
+++ sale/sale.py 2012-05-08 11:53:37 +0000
@@ -1127,7 +1127,7 @@
         try:
             value.update({
                 'product_uom_qty': product_uos_qty / product.uos_coeff,
- 'th_weight': product_uos_qty / product.uos_coeff * product.weight
+ 'th_weight': (product_uos_qty / product.uos_coeff) * product.weight
             })
         except ZeroDivisionError:
             pass

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

Seems bug is obsolete in last revision.

Regards

Nicolas

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

Got it in Sale layout use the on change ups_change but not the view in sale .py

We should remove this dead code.

Regards

Nicolas

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

in sale module sorry

[Amit Bhavsar (Open ERP) (amb-openerp)]

Hello Nicolas Bessi,

I have checked your Issue, But I am not able to understand your comment #2 and #3 properly. So would please more focus on this Issue and elaborate more .

Thanks and waiting for your reply!

[Amit Bhavsar (Open ERP) (amb-openerp)]

Hello Nicolas Bessi,

I am agree with you that, in sale order line th_weight it is not computed correctly with qty > 1.

So , It has been fixed onlp:~openerp-dev/openobject-addons/trunk-bug-996512-amb branch with following revision no and id.

rev no : 6797
rev id : 6797 <email address hidden>

Thanks for the reporting!