[6.1, 7.0] Draft invoice to pro-forma without check tax

Bug #941817 reported by Antoine on 2012-02-27
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
New
Medium
OpenERP R&D Addons Team 3
OpenERP Community Backports (Addons)
Status tracked in 7.0
6.1
Low
Stefan Rijnhart (Opener)
7.0
Low
Stefan Rijnhart (Opener)

Bug Description

In the workflow tax amount is check just for the invoice validation.

For example, on a draft invoice with lines, edit a line in changing quantity of product.
Save your invoice, amount is compute but tax is not compute and keep is old value. You can change from draft invoice to pro-forma and you send at your customer this document with wrong amount. You must be awake, check manually tax and compute it with compute button.

Related branches

Antoine (antoine-suj) wrote :

Bug 820801
https://bugs.launchpad.net/openobject-addons/+bug/820801

Same bug description but strange fix for me.

Antoine (antoine-suj) on 2012-02-27
tags: added: taxes
Ravish(OpenERP) (rmu-openerp) wrote :

Hello Antoine,

I have checked your issue. But it's working properly for me.
For your reference I have attached video ,Please take a look.If you refresh invoice will be in paid state

If you still faced the problem please inform us !

Thanks!

Changed in openobject-addons:
status: New → Invalid
Antoine (antoine-suj) wrote :

I see your video.
Imagine, after change the quantity, user forget to click on « Compute taxes ». He can make a pro-forma.
I think is dangerous and taxes must be check when you go on pro-forma state.

Changed in openobject-addons:
status: Invalid → Opinion
Antoine (antoine-suj) on 2012-04-13
Changed in openobject-addons:
status: Opinion → New
Amit Parik (amit-parik) wrote :

Hello Antoine,

As you said this is related to lp:820801 , for the solution of lp:820801 is solved your comment#3 's problem.

We have provided a "Compute Taxes" button also after the pro-forma, so for this type of problem just again compute the invoice after pro-forma,

I have attached a video for your more information,So would you please check it and notify me have you still faced the problem or not.

Correct me If I am wrong!

Thanks and waiting for your reply!

Amit Parik (amit-parik) wrote :
Changed in openobject-addons:
status: New → Incomplete
Antoine (antoine-suj) wrote :

For me, when you click on pro-forma button and invoice become a pro-forma with wrong amount it's a problem.
Ok you can click on compute but for me it's source of error, because you can send a pro-forma with wrong amount.

There no check amount on pro-forma (as validation step) in workflow. When you have pro-forma invoice may be you have an incorrect invoice. User must systematically clicked on compute button because pro-forma state does not guarantee right amount.

It should be impossible to have a pro-forma with wrong amount.
Why should it possible ?

Amit Parik (amit-parik) wrote :

Hello Antoine,

Thanks for the good explanation on this.

Now I totally agree with you we need to calculate the taxes on pro-forma button also because as per the following scenario.

Company 's accountant has created the invoice and set this as a pro-forma but forget to "Compute Taxes" then he print the invoice, sent to customer and waiting for this approval but sent invoice doesn't contains the taxes in this scenario.

After the approval accountant going to validate the invoice, now he will see the taxes on invoice so It will becoming a strange because customer doesn't know about the taxes. That's this will making a misconception between company and customer.

One more point we have to remove the Bharat's fix because It's useless, If we have properly fix this. So you are correct in your comment#1 this fixes is strange.

Now I am going to work on this and will fix asap.

Anyways I appreciate your passions on this issue.

Cheers!

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Medium
status: Incomplete → In Progress
Amit Parik (amit-parik) wrote :

Hello Antoine,

Thanks for the reporting!

This issue has been fixed on lp:~openerp-dev/openobject-addons/trunk-bug-941817-amp branch with following revision-no and rev Id.

rev no : 6732
rev ID : 6732 <email address hidden>

It will be merged with trunk soon.

Thank you!

Changed in openobject-addons:
status: In Progress → Fix Committed
TArpi (teksearpi) wrote :

Hi,

It, would be good to add this patch to the 6.1 addons, too.
Because it happened in our company that the proforma invoice was paid by the customer. After generating the final invoice there was a difference, witch has to be payed by the customer, and it was a little bit
The patch is OK and it should added asap to the addons, because it is about a functional issue.

Thanks,
TArpi

Amit Parik (amit-parik) wrote :

Hello Folks,

I am glad to announce that this bug is already fixed on trunk. Yeah.. :-).

Please check account_invoice_view.xml 's button Recompute taxes and total (button_reset_taxes) which is visible in both state draft,proforma2 as I was fixed on my branch.

So faithfully the bug is Fix Released.

Thank you!

Changed in openobject-addons:
status: Fix Committed → Fix Released

Reopening. This bug still exists in OpenERP 7.0

Changed in openobject-addons:
status: Fix Released → New
summary: - Draft invoice to pro-forma without check tax
+ [6.1, 7.0] Draft invoice to pro-forma without check tax

In 7.0, create a draft invoice with a line of €4 with a 21% tax. Click proforma button: total = €4. Click validate button: total = €4,84.

TArpi (teksearpi) wrote :

I'm confirming that this bug still exist in OpenERP 7. 0.

Until the fix released, here is a workaround. Put this in a custom module, in an xml file. Make sure it is included in __openerp__.py 's "update_xml" list.

<?xml version="1.0" encoding="utf-8"?>
<openerp>
    <data>

        <record id="account.act_proforma2" model="workflow.activity">
            <field name="wkf_id" ref="account.wkf"/>
            <field name="action">write({'state':'proforma2'})
button_reset_taxes()</field>
        </record>

    </data>
</openerp>

TArpi

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers