%d vs %s at hotel_reservation module

[Andriy Podanenko]

System : Linux-3.0.0-12-generic-i686-with-Ubuntu-11.10-oneiric
OS Name : posix
Distributor ID: Ubuntu
Description: Ubuntu 11.10
Release: 11.10
Codename: oneiric
Operating System Release : 3.0.0-12-generic
Operating System Version : #20-Ubuntu SMP Fri Oct 7 14:50:42 UTC 2011
Operating System Architecture : 32bit
Operating System Locale : uk_UA.UTF-8
Python Version : 2.7.2+
OpenERP-Client Version : 6.0.3
Last revision No. & ID :Bazaar Package not Found !Traceback (most recent call last):
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/netsvc.py", line 489, in dispatch
    result = ExportService.getService(service_name).dispatch(method, auth, params)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/service/web_services.py", line 599, in dispatch
    res = fn(db, uid, *params)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/osv/osv.py", line 122, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/osv/osv.py", line 196, in exec_workflow
    res = self.exec_workflow_cr(cr, uid, obj, method, *args)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/osv/osv.py", line 189, in exec_workflow_cr
    return wf_service.trg_validate(uid, obj, args[0], method, cr)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/wkf_service.py", line 80, in trg_validate
    res2 = instance.validate(cr, id, ident, signal)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/instance.py", line 48, in validate
    workitem.process(cr, witem, ident, signal, force_running, stack=stack)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/workitem.py", line 61, in process
    ok = _split_test(cr, workitem, activity['split_mode'], ident, signal, stack)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/workitem.py", line 174, in _split_test
    _join_test(cr, t[0], t[1], ident, stack)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/workitem.py", line 182, in _join_test
    create(cr,[activity], inst_id, ident, stack)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/workitem.py", line 41, in create
    process(cr, res, ident, stack=stack)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/workitem.py", line 53, in process
    result = _execute(cr, workitem, activity, ident, stack)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/workitem.py", line 107, in _execute
    wkf_expr.execute(cr, ident, workitem, activity)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/wkf_expr.py", line 68, in execute
    return _eval_expr(cr, ident, workitem, activity['action'])
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/workflow/wkf_expr.py", line 58, in _eval_expr
    ret = eval(line, env, nocopy=True)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/tools/safe_eval.py", line 284, in safe_eval
    return eval(test_expr(expr,_SAFE_OPCODES, mode=mode), globals_dict, locals_dict)
  File "", line 1, in <module>
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/osv/orm.py", line 181, in <lambda>
    return lambda *args, **argv: attr(self._cr, self._uid, [self._id], *args, **argv)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/addons/hotel_reservation/hotel_reservation.py", line 127, in _create_folio
    cr.execute('insert into hotel_folio_reservation_rel (order_id,invoice_id) values (%d,%d)', (reservation.id, folio))
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/sql_db.py", line 78, in wrapper
    return f(self, *args, **kwargs)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/sql_db.py", line 131, in execute
    res = self._obj.execute(query, params)
TypeError: %d format: a number is required, not str

[Andriy Podanenko (podarokua)]

Error appears when creating folio from reservation
fix is
line 127

before
            cr.execute('insert into hotel_folio_reservation_rel (order_id,invoice_id) values (%d,%d)', (reservation.id, folio))
after
            cr.execute('insert into hotel_folio_reservation_rel (order_id,invoice_id) values (%s,%s)', (reservation.id, folio))

[Andriy Podanenko (podarokua)]

here is a patch with fixed bug and corrected xmls for menu fix

[Amit Parik (amit-parik)]

Hello Andriy,

It has been fixed in lp:openobject-addons/extra-6.0 branch with following revision no and info.
5564 <email address hidden>

And for you menu item's issue has been already resolved in this same branch.

Thanks.