Return stock moves with parents is impossible

[Omar (Pexego)]

Hi,

If you have a move with parents moves inside any picking and you try return it, it fails, with this exception: "There are no products to return (only lines in Done state and not fully returned yet can be returned)!"
In the source, it checks if the quantity of move to return is less or equal than sum of quantities of his parents (move_history_ids2), that to know if this move was returned yet, but it's wrong, it must check his child moves (move_history_ids) where returns will be registered.

Regards.

[Omar (Pexego) (omar7r)]

I reattach the patch because this bug isn't in this line it is in all the file, move_history_ids2 is used instead of move_histoy_ids.

[Omar (Pexego) (omar7r)]

This isn't a good strategy for this objective, with my patch if the origin move was part of any production it can fail too, because the child quantity is more than move quantity.
Anyway this file uses move_history_ids2 (parents) instead of move_history_ids (childs), but it isn't a good strategy, this wizard must be rewrited.

[Omar (Pexego) (omar7r)]

Checking my last message it doesn't fail, only could return the available quantity, it is correct but with my patch applied, it need sum child moves quantities instead of parent move quantities.

[Vinay Rana (OpenERP) (vra-openerp)]

Hello Omar,

Would you please elaborate more, I can not get you exactly. I have checked this issue at my end by returning the created done picking and when I again try to call return picking wizard , It shows me same warning what you mention which is normal behaviour. But You did not mention this all things in bug specification, Would you please explain this case what you aspect and What you did get.

Thanks.

[Omar (Pexego) (omar7r)]

Hi Vinay,

Yes, because this wizard set the return move like parent of origin move, but it must be child of origin move, or not? Then int all file you must use move_history_ids instead of move_history_ids2.

Imagine that your origin move have parents, who aren't returns, this wizard checks all parents moves then the sum of parents quantity doesn't represent the consumes or returns quantity, this quantity is represented by children moves.

Test it, thanks

[Claire (cjin)]

Hi,

How can we fix it for now?

Thank you.

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

I've tagged this bug as duplicate of https://bugs.launchpad.net/openobject-addons/+bug/944025 which is being fixed by the openerp support team on the 6.0 and 6.1 branches.