Account_voucher : Onchange of amount removes all manually added lines

[Jay Vora (Serpent Consulting Services)]

Reference from https://bugs.launchpad.net/openobject-addons/+bug/767058

Check the video to demonstrate:

1. create some invoices for the same partner and validate them
2. select one of them and make the payment for that invoice
3. enter all data that are needed: Paid Amount (maybe partner pay's 500.--), Payment Method and Date
3.1 the selected invoice before will now be listed
4. press "New" (invoices and outstanding transactions)
4.1 select invoices that are also paid
4.2 save each single line, edit it again and enter the amount (where the invoice amount should be auto inserted, please!)
4.3 repeat that for other open invoices of this partner
5 check now the total open balance and total amount
6. change now the paid amount to another amount (maybe if the total amount don't fit paid amount or only for test)
6.1 lines are gone!!!

You can repeat that and maybe change Payment Method or Date... same happens

Btw. if you press "New" (invoices and outstanding transactions) the list always have all invoices instead of only those that arn't in the list of invoices and outstanding transactions...

video demonstration:
http://dl.dropbox.com/u/5636258/openerp-multi-invoice-payment.ogv (5MB)

Thanks.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Subscribers,

We consider this as a critical issue to fix as this needs major changes to be done.

Kindly accept the request to give us some time to fix it.

We hope you understand.

Thanks.

[Thomas Winteler (Win-Soft) (thomi)]

Hey Jay

Thanks for that.. and for working on it..

Just to inform, the problem is also with "onchange" on "Date" and "Payment method"..

regards
Thomas

[Jay Vora (Serpent Consulting Services) (jayvora)]

Thomas,

Yes, you are right. Calls of onchanges to partner_id is messing all this up.

We are working on it and assure you a best solution.

Thanks.

[Frederic Clementi - Camptocamp (frederic-clementi)]

thanks jay...we've been waiting for this one;)

[Priyesh (OpenERP) (pso-openerp)]

Hello Jay,

Its fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-bug-783496-pso.
It will be merged soon with stable-6.0.

Thanks for reporting.

[Thomas Winteler (Win-Soft) (thomi)]

Hey Priyesh

Thanks for creating this fix/enhancement ;)..

Have tested it and it works fine.. expect oft this:
if you select multiple invoices.. all already choosed invoices in the list of "Invoices and outstanding transactions" will also be listed if you add one more line... so.. a fault can be, that a invoice will be listed twice..

See the Video Demo:
http://dl.dropbox.com/u/5636258/openerp-account_voucher-list.ogv

Please update the function, that on adding a new line of "Invoices and outstanding transactions" only those invoices are listed, which are not in the list of "Invoices and outstanding transactions"..

About cycle of branch merging.. how long does it take normally, that a fix like this will be merged into stable-6.0? Will the Bug be updated, if the fix is merged into stable-6.0?

Thanks a lot
thomi

[Priyesh (OpenERP) (pso-openerp)]

Thomas,

I have commented on the relevant branch.

As far as the merging of the branch is concerned, it depends on the severity of the bug. Normally, within a week, it gets done.

If the bug is a blocking point, and the fix is of low-risk, we can merge with no hesitation.

Talking about this fix, it contains change in the parameters of the onchange method, so its not so easy to adopt such a change without making sure its effect on any other modules which might be using this method.

Thanks.

[Thomas Winteler (Win-Soft) (thomi)]

Hey Priyesh

Thanks for description.
I made some tests with multi invoice payment and it looks good.

There is one bug that show this error:
Traceback (most recent call last):

  File "/opt/openerp/production/server/bin/service/netrpc_server.py", line 69, in run

    msg = ts.myreceive()

  File "/opt/openerp/production/server/bin/tiny_socket.py", line 88, in myreceive

    res = unpickler.load()

UnpicklingError: Global and instance pickles are not supported.

How to reproduce:
1. pay any invoice
2. enter all data: Paid Amount, Payment Method, Date
3. press new "Invoices and outstanding transactions"
4. add any other open invoice (don't need to)
5. let the new, empty "Invoices and outstanding transactions" line as it is
6. change one of this: date, paid amount, payment method
7. above error message appears

Video demo: http://db.tt/TCrpi4M

Workaround:
> close/ESC the empty "Invoices and outstanding transactions" line

I think if that is fixed too, we got it ;).. and can update production instance of customers..

Thanks a lot for treatment

kind regards
thomi

[Mario Arias (the-clone-master)]

Hi,

It has been five months from publishing of this fix, but it is still not merged into stable...

It can be difficult for some to find out about a fix being available, or even notice the problem in the first place until it has been in production for some time...

Please help complete the merge proposal... ;-)

Regards,
-Mario

[Mario Arias (the-clone-master)]

Also, if there are supplier refunds, this fix messes them...

Create a couple invoices and refunds for the same supplier.
Create a new supplier payment. All invoices and refunds are shown... So far so good...
Change the amount paid or the payment method... The refunds are gone...

Regards,
-Mario

[Thomas Winteler (Win-Soft) (thomi)]

Hey

Today upgraded to latest revno:
addons 5257
server 4624
web 4826

This problem still exists...

Long time since last action on the report.. why?
As i know, this is under OPW 5577..

Please fix it, yes in 6.0.4...

thomi

[Mario Arias (the-clone-master)]

Moved to account_voucher_enapps and stopped suffering...

At last a functional account_voucher module, a shame it is not from OpenERP ... !!

I can not understand how such a basic feature has so many problems and almost no one is complaining... really don't get it...

-Mario

[Cristian Salamea (ovnicraft)]

Hello Thomas the fix is not merged yet but if you want test the patch you can get it from the branch linked.

Regards,

[Cristian Salamea (ovnicraft)]

There is any news about this bug ? was reported 2011-05-16 but nothing says about merge.

Please updated.

Regards,

[tozm (tozm)]

Is this fix also slated for inclusion in 7.0 trunk any time soon? I agree with other commenters... why is such an important fix not being given any priority?

[invitu (invitu)]

I think the behaviour is correct in last 6.0 release

[Michael Karrer (michaelkarrer81)]

I would be also very interested if this bug affects 7.0 also?!?

[Mario Arias (the-clone-master)]

This bug is still present, even on 7.0 and trunk !!

How is it possible to use unpatched account_voucher in real life ??

Are current SaaS users so basic that they are not affected by this ??

Please apply correction to all versions...

[Mario Arias (the-clone-master)]

Also, correct fix should be to only reload open moves when changing partner...

So onchange should be split in two... one for partner and another for the other changes currently mixed.

[Michael Karrer (michaelkarrer81)]

Any news on this bug? Why is OpenERP not responding to such critical bugs? There seems to be no one around from OE here?

[Michael Karrer (michaelkarrer81)]

Wow this bug is from 2011 - thats kind of scary!