hr_timesheet_invoice: reinvoicing is not correctly set on analytic account lines

Bug #734497 reported by kervel on 2011-03-13
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 3

Bug Description

I tried to configure reinvoicing on my openerp install, but despite correct (i think) settings in the analytic accounts, the "reinvoice" setting is not propagated to the invoice lines. This stops the re-invoicing task (recurring activities -> billing -> bill tasks) from working normally.

See http://www.openerp.com/forum/post77451.html

the reason is 2 things:
* account_move_line.create creates its own analytic invoice lines, ignoring the invoice lines supplied as values (so the whole hr_timesheet_invoice invoice lines creator logic is doing nothing)

* the analytic account lines are then deleted and recreated again by account.validate, so even if i changed above behaviour, it would still not work.

proposed fix (see attached patch) is overriding account_move_line so that it changes the analytic lines to set the right to_invoice based on analytical account.

greetings,
Frank

Related branches

kervel (frank-dekervel) wrote :

hmm, seems uploading the patch didn't work. trying again

Amit Parik (amit-parik) wrote :

Hello Kervel,

I have checked your issue and it is working as expected.
would you please elaborate this with proper example or screenshots.

Thanks.

Changed in openobject-addons:
status: New → Incomplete
kervel (frank-dekervel) wrote :

Hello,

i tried to make a pdf document with all steps required to reproduce the bug.

Is this what you need ?

Frank

Amit Parik (amit-parik) wrote :

Hello kervel,

Thanks for your reply.

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Low
status: Incomplete → Confirmed
Changed in openobject-addons:
status: Confirmed → In Progress
Priyesh (OpenERP) (pso-openerp) wrote :

Hello,

Its fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-734497-pso
Rev-no: 4627
Rev-Id: <email address hidden>

It will be merged soon with Addons branch.

Thanks for your contribution.

Changed in openobject-addons:
status: In Progress → Fix Committed
Changed in openobject-addons:
milestone: none → 6.1
qdp (OpenERP) (qdp) on 2011-04-21
Changed in openobject-addons:
status: Fix Committed → Fix Released
Stéphane Bidoul (Acsone) (sbi) wrote :

For the record, the fix for lp:948876 modified the fix for this one.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments