report task complete with email customer generate fatal error (With Mail Header )

[Jan Verlaan]

Version 6.0.1.

Create a project where manager and customer is updated via email when a task is completed.
Create a task en complete this task.

A email screen does pop-up with the the email-addresses from manager and customer.
Sent the email. Next fatal error is generated:

Traceback (most recent call last):
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/netsvc.py", line 489, in dispatch
    result = ExportService.getService(service_name).dispatch(method, auth, params)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/service/web_services.py", line 599, in dispatch
    res = fn(db, uid, *params)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/osv/osv.py", line 122, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/osv/osv.py", line 176, in execute
    res = self.execute_cr(cr, uid, obj, method, *args, **kw)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/osv/osv.py", line 167, in execute_cr
    return getattr(object, method)(cr, uid, *args, **kw)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/addons/project/wizard/project_task_close.py", line 102, in send
    header = (project.warn_header or '') % val
KeyError: u'date'

[Amit Parik (amit-parik)]

Hello Jan Verlaan,

I have tested your scenario with the latest code at my end, but I am not able to reproduce it.
Would you please elaborate with more or provide the more information to reproduce it.

Thanks

[Jan Verlaan (jan-verlaan)]

Finally I have found the problem that generates the fatal error.
Into the mail message that can be defined into the projectheader on the thirt tab, user can define some vaiables like
State: %(state)s and Task: %(name)s

Into the Dutch help below in screen there is named for the first variable % (state)s <= notice the space between % and (
That is generating the fatal error. After removing the space the eroor is gone and the email is sent.

A fatal error is in all circumstances not the way the program should inform the user for a error. Please rethink for a better user friendly message to the user that will point him to the place to correct his error.

Kins regards,
Jan

[Amit Parik (amit-parik)]

Hello Jan Verlaan,

Thanks for your quick reply.

[Jigar A. (ifixthat)]

Hello,
         I have fixed this Bug and committed to the lp:~openerp-dev/openobject-addons/jam-dev-addons1 at revision:
           + revno: 3715
           + revision-id: <email address hidden>
        and will be soon merged to the lp:openobject-addons.

Thank You

[Jan Verlaan (jan-verlaan)]

Helptext in Dutch is now corrected too!

Thanks,
Jan