Base_sale_multichannels Payment Validation

[Kyle Waid]

Newest Branch extra-addons-trunk, addons, openobject-server
Maverick 10.10 linux

If validate payment box is checked, error returned. If validate payment box not checked. No error.

File "/usr/local/lib/python2.6/dist-packages/openerp-server/addons/openerp6-module/sale.py", line 133, in import_shop_orders
    resp = self.pool.get('sale.order').mage_import_base(cr, uid, context.get('conn_obj', False), shop.referential_id.id, defaults=defaults, context={'one_by_one': True, 'ids_or_filter':ids_or_filter})
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/addons/openerp6-module/magerp_osv.py", line 236, in mage_import_base
    rec_result = self.ext_import(cr, uid, rec_data, external_referential_id, defaults, context)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/addons/base_external_referentials/external_osv.py", line 206, in ext_import
    crid = self.oe_create(cr, uid, vals, each_row, external_referential_id, defaults, context)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/addons/openerp6-module/sale.py", line 404, in oe_create
    paid = self.create_payments(cr, uid, data, order_id, context)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/addons/openerp6-module/sale.py", line 421, in create_payments
    self.generate_payment_with_pay_code(cr, uid, payment['method'], order.partner_id.id, amount, "mag_" + payment['payment_id'], "mag_" + data_record['increment_id'], order.date_order, paid, context)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/addons/base_sale_multichannels/sale.py", line 293, in generate_payment_with_pay_code
    return self.generate_payment_with_journal(cr, uid, payment_settings.journal_id.id, partner_id, amount, payment_ref, entry_name, date, payment_settings.validate_payment, context)
  File "/usr/local/lib/python2.6/dist-packages/openerp-server/addons/base_sale_multichannels/sale.py", line 317, in generate_payment_with_journal
    self.pool.get('account.bank.statement').button_confirm(cr, uid, [statement_id], context)
AttributeError: 'account.bank.statement' object has no attribute 'button_confirm'

Error reproduced on clean install, every time.

[Kyle Waid (midwest)]

Solution:

This is because in the Current trunk version of open-object addons account module, the attribute button_confirm was replaced with button_confirm_bank which indeed clears the error but errors at the next line citing index out of range. This line is additional to the older connector.

[Vinay Rana (OpenERP) (vra-openerp)]

Hello,

Our R&D Teams are focused on the latest OpenERP version, and this issue does not affect it.
We stand of course ready to backport the change to stable releases if it has an impact on any customer. In this case please report it to our maintenance team via the OpenERP Publisher's Warranty. They will quickly help solve the issue and backport the fix if needed.

Thanks.

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Hello Kyle and all,

thank you for pointing us to the bug. We had a v6 customer that was not impacted because payments were generated using Brazilian "Boletos" with TerminatOOOR instead, but yes, it was truly a bug due to some recent change in OpenERP v6 bank statement/vouchers management.

Kyle, think you for the support, I finally did what I wanted since a long time ago: on v6 we finally have decent vouchers and the "customer payment" entity based on it.
So now base_sale_multi_channels depends on the "account_voucher" module. So you should install it and also do an "update module list" action in the admin menu.

Now, if you set magentoerpconnect to generate payments for your Magento payment type (in the accounting menu), you'll find payments in the Accounting>Customer>Customer Payment menu now (validated or now, depends what you set).

Bank statements might still be used along with magentoerpconnect, for instance if you want to really import some bank file and possibly automatically reconcile those vouchers based on the bank file. But at least now we don't have vouchers and bank statements all mixed together, this is much better I think.

the fix has been committed in the trunk-addons rev #5095
You would also need to upgrade magentoerpconnect to magentoerpconnect/openerp6-module #377 to avoid any trouble.

Best regards