invoice from packing wrong price/unit if product has uos
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Odoo Addons (MOVED TO GITHUB) |
Fix Released
|
Medium
|
OpenERP R&D Addons Team 2 | ||
Bug Description
If :
- a product has both UOM and UOS fixed by a coefficient in the product
- invoice is generated packing based on quantities delivered
- 1 UOM = 5 UOS
Sales order uses UOM and corresponding quantity to calculate line subtotal = uom_qty * unit price. It means that price in sales order reflects price per UOM not per UOS
Packing uses UOM
When Invoice is generated from packing the unit used on invoice is UOS and quantity is uos_qty.
But the price is taken from sales order which is price per UOM resulting in 5 times higher subtotal for the invoice line in this case.
To reproduce :
1. define a product with both UOM and UOS
2. create a sales order with the product with mode invoice from picking
3. confirm picking for sales order
4. create invoice from picking
amounts on sales order and invoice are different
Proposed solution :
of of the three but I am not sure which is most consistent with the rest of the system
1. use UOM and uom_qty on invoice
2. adjust price_unit on invoice to reflect price per UOS
3. use UOS and price per UOS in sales order but probably it will screw up everything else later in the chain
Related branches
- Atik Agewan(OpenERP) (community): Needs Resubmitting
- OpenERP Core Team: Pending requested
-
Diff: 775 lines (+91/-131)37 files modifiedaccount/i18n/pt_BR.po (+2/-3)
account/report/account_balance.py (+2/-0)
account/wizard/account_move_journal.py (+1/-1)
account/wizard/account_open_closed_fiscalyear.py (+2/-0)
account/wizard/account_report_balance_sheet.py (+2/-1)
account/wizard/account_report_common.py (+4/-1)
account/wizard/account_report_general_ledger.py (+1/-1)
account/wizard/account_report_partner_balance.py (+1/-1)
account/wizard/account_report_partner_ledger.py (+1/-1)
account/wizard/account_report_profit_loss.py (+1/-1)
account/wizard/account_validate_account_move.py (+3/-0)
account/wizard/account_vat.py (+3/-0)
account_invoice_layout/i18n/hu.po (+3/-3)
auction/wizard/auction_pay_sel.py (+5/-5)
board/wizard/board_menu_create.py (+3/-3)
email_template/wizard/email_template_send_wizard.py (+10/-10)
hr_timesheet/i18n/pt_BR.po (+1/-1)
hr_timesheet/wizard/hr_timesheet_print_employee.py (+3/-1)
hr_timesheet_invoice/wizard/hr_timesheet_final_invoice_create.py (+3/-0)
mrp/i18n/es_AR.po (+2/-3)
mrp/wizard/mrp_product_produce.py (+2/-2)
pad/__openerp__.py (+1/-1)
point_of_sale/i18n/pt_BR.po (+1/-1)
project_scrum/wizard/project_scrum_backlog_create_task.py (+4/-2)
project_scrum/wizard/project_scrum_backlog_sprint.py (+3/-0)
purchase/purchase.py (+7/-4)
purchase_requisition/wizard/purchase_requisition_partner.py (+4/-5)
stock/i18n/stock.pot (+0/-5)
stock/wizard/stock_move.py (+0/-29)
stock/wizard/stock_move_view.xml (+0/-28)
stock/wizard/stock_split_move.py (+1/-1)
survey/wizard/survey_browse_answer.py (+7/-8)
survey/wizard/survey_print.py (+2/-3)
survey/wizard/survey_print_answer.py (+1/-1)
survey/wizard/survey_print_statistics.py (+1/-1)
survey/wizard/survey_selection.py (+3/-3)
survey/wizard/survey_send_invitation.py (+1/-1)
- Atik Agewan(OpenERP) (community): Needs Resubmitting
- Rucha (Open ERP) (community): Needs Fixing
-
Diff: 134 lines (+15/-11)9 files modifiedboard/wizard/board_menu_create.py (+3/-1)
stock/wizard/stock_move.py (+1/-1)
stock/wizard/stock_split_move.py (+1/-1)
survey/wizard/survey_browse_answer.py (+3/-1)
survey/wizard/survey_print.py (+2/-2)
survey/wizard/survey_print_answer.py (+1/-1)
survey/wizard/survey_print_statistics.py (+1/-1)
survey/wizard/survey_selection.py (+2/-2)
survey/wizard/survey_send_invitation.py (+1/-1)
- OpenERP Core Team: Pending requested
-
Diff: 513 lines (+95/-74)16 files modifiedmrp/mrp.py (+20/-2)
mrp_operations/mrp_operations.py (+8/-2)
procurement/procurement_view.xml (+3/-2)
product/pricelist.py (+4/-4)
product/product.py (+3/-3)
product/report/pricelist.py (+1/-1)
product_margin/product_margin_view.xml (+3/-0)
project_mrp/project_procurement.py (+1/-1)
purchase/purchase.py (+8/-5)
purchase/purchase_view.xml (+6/-6)
stock/stock.py (+15/-13)
stock/wizard/stock_invoice_onshipping.py (+2/-2)
stock/wizard/stock_location_product.py (+1/-1)
stock/wizard/stock_move.py (+0/-28)
stock/wizard/stock_partial_picking.py (+19/-3)
stock/wizard/stock_return_picking.py (+1/-1)
| Piotr Buszka (piotr-buszka) wrote | #1 |
| Changed in openobject-addons: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| assignee: | nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2) |
| Changed in openobject-addons: | |
| status: | Confirmed → In Progress |
| Atik Agewan(OpenERP) (aag-openerp) wrote | #2 |
| Changed in openobject-addons: | |
| status: | In Progress → Fix Released |
Forgot to put system info:
openerp-server 5.0.14
Ubuntu 10.04 64bit
GTK and web client