Invoice on Shipped Quantities doesn't update services

[Sami Haahtinen]

The "Invoice on" field for a sales order appears to work correctly for items only. If the "Invoice on" field is set to "Shipped Quantities" and the invoice contains services the services are always invoiced as ordered even if the amount is updated.

This bug applies to the 5.0 series and was most recently verified with the 5.0.11 release.

There is a fix for this bug in the following branch:
https://code.launchpad.net/~ressu/openobject-addons/project_mrp_invoicing

[Ana Juaristi Olalde (ajuaristio)]

Hi Sami:

I don't understand the bug, since services are not included on shipping. Conceptually you don's send services, so this is correct.

IMHO it has nosense setting "Invoice on" field to "Shipped Quantities" on services.

Thank you...

[Sami Haahtinen (ressu)]

On Sun, 2010-10-17 at 10:19 +0000, Ana Juaristi Olalde wrote:
> I don't understand the bug, since services are not included on shipping.
> Conceptually you don's send services, so this is correct.
>
> IMHO it has nosense setting "Invoice on" field to "Shipped Quantities"
> on services.

This covers the case of invoicing based on hours used for the sales
order. When used with project_mrp module, each sales order is converted
in to a task. This makes managing incoming work orders work with the
same basic workflow as with products.

Now, when the sales order is created you can't accurately predict how
many hours of work will be included in the task assigned, so one
provides the estimate given to the customer. Once the sales order is
approved project_mrp will create the appropriate tasks and the work can
be completed through the project module as usual. Once the project is
marked as done the invoice will be created as a draft invoice with the
actual hours worked.

The "Shipped Quantities" is an unfortunate choice for a name, but it's
the only one that fits the workflow.

This workflow is actually described here:
http://doc.openerp.com/book/4/4_13_Projects/4_13_Projects_management.html#invoicing-tasks

The only problem with that above mentioned workflow is that it is
incomplete on the system side and the actual hours aren't reflected in
the invoice. This patch fixes this workflow with minimal impact on those
systems which do not use this workflow (or project_mrp module).

--
Sami Haahtinen <email address hidden>

[Vinay Rana (OpenERP) (vra-openerp)]

Hello,

Our R&D Teams are focused on the latest OpenERP version, and this issue does not affect it.
Our policy is to keep the changes applied on stable branches to a minimum, in order to limit the regression risks for customers that are in production. This means that bugs reported on Launchpad are fixed in the trunk branch only by default, even if they were reported against other stable versions.
We stand of course ready to backport the change to stable releases if it has an impact on any customer. In this case please report it to our maintenance team via the OpenERP Publisher's Warranty. They will quickly help solve the issue and backport the fix if needed.
Thank you for your understanding!