stock_planning : Needs improvements

[Diego Abad]

Hello, I am testing stock_planning module for 6.0, I found this bug.

stock_planning/stock_planning.py
line 355, in product_amt_change
    ret['product_qty'] = rounding(coeff_def2uom * product_amt/(val.product_id.product_tmpl_id.list_price), round_value)
UnboundLocalError: local variable 'rounding' referenced before assignment

To reproduce,
Menu Sales -> Stock and Sales Forecast -> Stock and Sales Forecast
Select one forecast, change to form view, and change product_amt field. The bug is on on_change function.

[Grzegorz Grzelak (OpenGLOBE.pl) (grzegorz-og.pl)]

In line 354 you should change rounding to round_value.

[Bhumika Shrimali (sbh-openerp)]

Hello,
        This bug has all ready been fixed in lp:~openerp-dev/openobject-addons/trunk-dev-addons3 branch.
    I have attach the patch for this bug.

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

hello Diego,

We have fixed the bug in above branch specified by sbh. And the that branch will be merge with trunk addons soon.

Thank you,
Mustufa (mra)

[JMA(Open ERP) (jma-openerp)]

Hello,

The module still needs refactoring.
Onchange is never supposed to work for unsaved records.

Thanks.

[Richard (John) Nopkins@Servosoft (richard-nopkins)]

Hi Diego, nice posting.
i would rather go for the full module changements.

@Grzegorz Grzelak, très bon travail sur la description du module.

last comment #5 makes more sense for my happy customers.
consistency is amatter of fact: SO,PO and invoicing have onchnages working for new record, it crashes here.

sorry for my bad english. :((

@diego , (is it diego maradona?)

[Meera Trambadia (OpenERP) (mtr-openerp)]

Hello,

We have fixed the bug and made improvements in the lp:~openerp-dev/openobject-addons/trunk-dev-addons3 branch.This branch will be merged with trunk addons soon.

Thanks.

[Richard (John) Nopkins@Servosoft (richard-nopkins)]

hi,

des changements impressionnants dans la qualité du code MTR (OpenERP) (MTR-OpenERP).
son vraiment fascinant de voir ce genre de code.

I meaned i am nice to see this qwuality changes. (you mai translaet it).

but,what i felt uncomfortable was why onchange returned null set {} for ids ? it doesnt work for unsaved records.
i repeat #6.

consistency is amatter of fact: SO,PO and invoicing have onchnages working for new record,for an unsaved record, i now get no crash, but it does nothng.

many thnks and wishes.

[Richard (John) Nopkins@Servosoft (richard-nopkins)]

if possible, i will attach a patch, but i am not good at python.

[Ujjvala Collins (uco-openerp)]

Hello All,

It has has been fixed and committed by revision: 4388 <email address hidden>

Thanks.