Sequence in product.packaging is not used for sort [5.0]

Bug #596940 reported by Niels Huylebroeck on 2010-06-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
Niels Huylebroeck

Bug Description

The model does not define an _order = "sequence"

So when in the code in product_id_change (in sale.order.line) is executed the the result of the call to:

        if not packaging and product_obj.packaging:
            packaging = product_obj.packaging[0].id
            result['product_packaging'] = packaging

... will yield the packaging to be the first inserted record instead of taking lowest sequenced packaging.

Changed in openobject-addons:
assignee: nobody → Niels Huylebroeck (niels-bubbles-it)
Changed in openobject-addons:
status: New → Fix Committed

Niels?.

Don't you think "fix-commited" will be when your branch has been merged? I
think the state should be "in progress"

THX

2010/6/21 Niels Huylebroeck <email address hidden>

> ** Changed in: openobject-addons
> Status: New => Fix Committed
>
> --
> Sequence in product.packaging is not used for sort [5.0]
> https://bugs.launchpad.net/bugs/596940
> You received this bug notification because you are a member of OpenERP
> Drivers, which is subscribed to OpenObject Addons.
>
> Status in OpenObject Addons Modules: Fix Committed
>
> Bug description:
> The model does not define an _order = "sequence"
>
> So when in the code in product_id_change (in sale.order.line) is executed
> the the result of the call to:
>
> if not packaging and product_obj.packaging:
> packaging = product_obj.packaging[0].id
> result['product_packaging'] = packaging
>
> ... will yield the packaging to be the first inserted record instead of
> taking lowest sequenced packaging.
>
>
>

--
Saludos Cordiales

Nhomar G. Hernandez M.
+58-414-4110269
+58-212-6615932
+58-212-9536734 ext 124
+58-212-9512643
Skype: nhomar00
Web-Blog: http://geronimo.com.ve
Servicios IT: http://openerp.netquatro.com
Linux-Counter: 467724
Correos:
<email address hidden>
<email address hidden>

Don't know honestly, you still have fix-released though, so maybe when
merge is accepted then it should be fix-released ?

Because I dont think OpenERP goes around at the time of release and only
setting bugs to fix-released when they do a release.

They set it already to released as soon as it's in the stable.

If not I hope someone from OpenERP will tell me and I'll adjust to their
preferences.

Regards,
Niels

Nhomar Hernández - http://openerp.netquatro.com wrote:
> Niels?.
>
> Don't you think "fix-commited" will be when your branch has been merged? I
> think the state should be "in progress"
>
> THX
>
> 2010/6/21 Niels Huylebroeck <email address hidden>
>
>
>> ** Changed in: openobject-addons
>> Status: New => Fix Committed
>>
>> --
>> Sequence in product.packaging is not used for sort [5.0]
>> https://bugs.launchpad.net/bugs/596940
>> You received this bug notification because you are a member of OpenERP
>> Drivers, which is subscribed to OpenObject Addons.
>>
>> Status in OpenObject Addons Modules: Fix Committed
>>
>> Bug description:
>> The model does not define an _order = "sequence"
>>
>> So when in the code in product_id_change (in sale.order.line) is executed
>> the the result of the call to:
>>
>> if not packaging and product_obj.packaging:
>> packaging = product_obj.packaging[0].id
>> result['product_packaging'] = packaging
>>
>> ... will yield the packaging to be the first inserted record instead of
>> taking lowest sequenced packaging.
>>
>>
>>
>>
>
>
>

Fix merged in revision 2763 <email address hidden> in addons-5.0.
It was already fixed in trunk.

Note: to answer your question, we don't use 'Fix Committed' a lot, we set to 'Fix Released' when the fix has landed on official branches, which means it's getting released with the next patch release. In most case you should probably set the status to 'In progress' until that happens unless you are very sure that the fix you proposed for merging is going to be accepted (which was indeed the case here).

Changed in openobject-addons:
importance: Undecided → Low
milestone: none → 5.0.12
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers