Entry by statement (bank statement) patch

Bug #523800 reported by Ferdinand
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Undecided
Unassigned

Bug Description

branch-server 1902
branch-addons official 2580
branch-addons chricar_5.0_price_unit 2514

see also discussion
<email address hidden>
subject: Entries by Statements - shortcoming
and blueprint
https://blueprints.launchpad.net/openobject-addons/+spec/entries-by-statement

this patch fixes
* does not set unusable and hence dangerous (users believe that default values are correct) default values
* sets customer/supplier from res_partner (reordered fields) - wizard still missing
* attrs="{'readonly':[('state','!=','draft')]}" for bank:statement lines

Revision history for this message
Ferdinand (office-chricar) wrote :

will provide extended patch later - after fixing some errors in code.

Revision history for this message
Ferdinand (office-chricar) wrote :

additional fixes
* does not write partner_id into move of the bank account (only into move of payables/receivbales) (a show stopper)
* creates/proposes period_id from date (comfort)

2 comments hidden view all 110 comments
Revision history for this message
Ferdinand (office-chricar) wrote :

* improved handling of supplier/customer

1 comments hidden view all 110 comments
Revision history for this message
Ferdinand (office-chricar) wrote :

Fixed:
* fetches next statement number from sequence defined in account journal, respects yearly sequences

ToDo
* init date in bank statement_lines - copy date from bank statement
* forbid or modify Copy bank statement
** Copy must not copy account_move_lines (SERIOUS ERROR as it copies confirmed lines)
** Copy must fetch next statement number (just provide empty statment number)

4 comments hidden view all 110 comments
Revision history for this message
Ferdinand (office-chricar) wrote :
Revision history for this message
Ferdinand (office-chricar) wrote :

Fixed:
* init date in bank statement_lines - copy date from bank statement
* added extensive help text

I would be happy if someone can fix the "copy issue" mentioned in
https://bugs.launchpad.net/openobject-addons/ bug/523800/comments/8

Not sure how to do this.

After this I consider the "Entries by Statements" usable and ready for production. (Data Entry didn't try import)

Revision history for this message
Ferdinand (office-chricar) wrote :

the patch works against branch 5.0 rev no 2602
except the help text for Bank statements , these are rejected for unknow reason

Changed in openobject-addons:
assignee: nobody → Jay (Open ERP) (jvo-openerp)
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Thank you for assignation Ferdinand.

I am looking upon the issues.

Changed in openobject-addons:
importance: Undecided → High
importance: High → Undecided
Revision history for this message
Ferdinand (office-chricar) wrote :

pls see fix
https://bugs.launchpad.net/openobject-addons/+bug/526930

this fix is not necessary, because fixed by 526930
* does not write partner_id into move of the bank account (only into move of payables/receivbales) (a show stopper)

Ill porvide a patch today

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

I'm Investigating more if It could be fixed by any best way.
Thanks for your time.

Revision history for this message
Ferdinand (office-chricar) wrote :

this works for me ( partner_id is set again)

Revision history for this message
Ferdinand (office-chricar) wrote :

sorry one more issue
"account_bank_statement.py"

this reuses now the same number as for statement - I have disabled it for me
#'name': lambda self,cr,uid,context={}: self.pool.get('ir.sequence').get(cr, uid, 'account.bank.statement.line'),

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

30 comments hidden view all 110 comments
Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Revision history for this message
Ferdinand (office-chricar) wrote :

sequence_id: should be used for numbering of account moves
invoice_sequence_id: (better sheet/voucher/...) should be used for numbering of internal and external documents

Changed in openobject-addons:
status: New → Triaged
Changed in openobject-addons:
assignee: Jay (OpenERP) (jvo-openerp) → nobody
status: Triaged → Fix Released
17 comments hidden view all 110 comments
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Considerable improvements have taken place inside trunk.
You can open another bug if anything is missing.
Thanks.

Changed in openobject-addons:
milestone: none → 6.0
Displaying first 40 and last 40 comments. View all 110 comments or add a comment.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Patches