[5.0] hr_holidays summary report goes weird on start date 1 (or 2) januari

Bug #423733 reported by Niels Huylebroeck
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Undecided
Niels Huylebroeck

Bug Description

The code assumes that if there is less than 30 days to go it only needs to output one month.
The linked branch has a fix where it really checks the amount of days in the coming month.

There might be a problem in that file as i see the code constantly using lengthmonth(year,month+i) + 1
Not sure why the +1 is there on the other calls to lengthmonth but I had to remove them for it to work when i was checking day_diff1 to the lenth of days in a month.

Changed in openobject-addons:
assignee: nobody → Red15 (niels-bubbles-it)
status: New → Fix Committed
Revision history for this message
Niels Huylebroeck (red15) wrote :

hang on, checking fix, seems not to work when i did it on clean code.

Changed in openobject-addons:
status: Fix Committed → Confirmed
Revision history for this message
Niels Huylebroeck (red15) wrote :

found out the +1 on line 133 was still causing problems, removed it and updated the main description

description: updated
Changed in openobject-addons:
status: Confirmed → Fix Committed
Revision history for this message
Niels Huylebroeck (red15) wrote :
Changed in openobject-addons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.