copy product needs to add "(copy)" to the product name/variant

[Ferdinand]

the copy process should add "(copy)" to the product name ot variant name

the message "working now on the duplicate document" is only temporary
it the user does not alter the name immediately and closes the tab it's difficult to find out which one is the copy

[Ferdinand (office-chricar)]

=== modified file 'product/product.py'
--- product/product.py 2009-08-07 07:26:47 +0000
+++ product/product.py 2009-08-07 11:31:40 +0000
@@ -633,6 +633,11 @@
     def copy(self, cr, uid, id, default=None, context=None):
         if not context:
             context={}
+ product = self.browse(cr, uid, id, context=context)
+ if not default:
+ default = {}
+ default = default.copy()
+ default['name'] = (product['name'] or '') + ' (copy)'

         if ('variant' in context) and context['variant']:
             fields = ['product_tmpl_id', 'active', 'variants', 'default_code',

[Jay Vora (Serpent Consulting Services) (jayvora)]

Corrected by revision 2314 <email address hidden>.

Thanks.

[Niels Huylebroeck (red15)]

What is the point of

if not default:
        default = {}
        default = default.copy()

A copy of an empty dictionary ?

[gpa(OpenERP) (gpa-openerp)]

Hello Red 15,

default = default.copy()
if not default:
        default = {}

Is this code preferable?

Thanks for reporting

[Niels Huylebroeck (red15)]

It's just I hate to see something so glaringly wrong going into trunk and possibly stable later.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Red15,

Corrections made in revision 2317 <email address hidden>.

Here, translation is also taken into consideration.

Thank you for pointing.

[Niels Huylebroeck (red15)]

Instead of doing this only on the product level, wouldn't it be advisable to do this in orm itself ?

This way other modules made by other people would also not suffer from this temporary indicator problem.

[Ferdinand (office-chricar)]

I strongly support suggestion https://bugs.launchpad.net/openobject-addons/+bug/410164/comments/7

[Jay Vora (Serpent Consulting Services) (jayvora)]

Yes, Its acceptable.

But, its not necessary that every object uses the copy() of its super.
It is possible that any object uses copy() by its own.

Anyways, we have taken the suggestion into consideration.

Many thanks.