The calculation of taxes in invoices doesnt honor the server switch "--price_accuracy"

[Numérigraphe]

Using the current stable 5.0 branches from LP
If the server instance is started with "--price_accuracy=3", the price accuracy in the rounding of taxes is not precise enough (rounding to 2 digits).
This makes it impossible to validate some invoices, because the resulting accounting moves are not balanced.

The patch proposed by Raphaël Valyi in Bug #328077 is a way to work around this problem, but probably not a solution - the same problem will arise with "--price_accuracy=6"

Yours,
Lionel.

[Numérigraphe (numerigraphe)]

I addition to this bug, the same problem seems to show up in the class account_payment_term terms too, with the same ill effect of making the invoice unbalanced.
I worked it around it by changing rount(..., 2) to rount(..., 5) but this is not a clean soultion.
Lionel.

    def compute(self, cr, uid, id, value, date_ref=False, context={}):
#...
     if line.value == 'fixed':
                amt = round(line.value_amount, 2)
            elif line.value == 'procent':
                amt = round(value * line.value_amount, 2)
            elif line.value == 'balance':
                amt = round(amount, 2)
#...t

[Numérigraphe (numerigraphe)]

Here is a patch that should fix this bug, inspired by the fix of Bug #424214 by Jay.
Could you please review it in include it in v5.0 ?

Please note that this does NOT fix the related Bug #328077, for which we could use
"config['price_accuracy']+3" instead of just "config['price_accuracy']".

Lionel.

[Numérigraphe (numerigraphe)]

Patch proposed, please review

[Numérigraphe (numerigraphe)]

Now I'm not too sure this is the way to go. I'm going to study the matter a little further...

[Numérigraphe (numerigraphe)]

I just realized that I encountered this error because I had made mistakes when I altered my database to suite --price-accuracy=3 instead of 2 - I had changed too many fields to decimal(...,3). After fixing my database, I can't reproduce the problem anymore.
So this may not be a bug after all, just optimistic programming - the code counts on the database to round values in some places.
SME you marked this "confirmed", have you been able to reproduce this ? If not, you can mark it invalid.
Lionel.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Lionel,

Fixed on server by revision 1853 <email address hidden>.
Fixed on addons by revision 2414 <email address hidden>.

Kindly check it and notify us.

Thanks.

[Numérigraphe (numerigraphe)]

Thanks Jay,
I can confirm the problem is fixed on our setup even if I transform all
decimal(16,2) fields to decimal(16,3).
Lionel

Jay (Open ERP) a écrit :
> Hello Lionel,
>
> Fixed on server by revision 1853 <email address hidden>.
> Fixed on addons by revision 2414 <email address hidden>.
>
> Kindly check it and notify us.
>
> Thanks.
>
> ** Changed in: openobject-server
> Status: New => Confirmed
>
> ** Changed in: openobject-server
> Status: Confirmed => Fix Released
>
> ** Changed in: openobject-addons
> Status: In Progress => Fix Released
>
>