Argument hardcoding in account

Bug #387741 reported by Corentin Pouhet-Brunerie - http://www.Smile.fr
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Undecided
Unassigned

Bug Description

Revision
Addons: 2343

The argument "vals" is hardcoded for the write method in the following files:
/account/account.py:2155
/l10n_ch/wizard/journal_config.py:113
/l10n_ch/wizard/journal_config.py:128
/l10n_ch_chart_c2c_pcg/wizard/config.py:91
/l10n_ch_chart_c2c_pcg/wizard/config.py:106

That's not so pretty...
Thus, when you want to override the write method, you must call values argument "vals".

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hello Corentin,
Write() has only 2 main arguements , list of ids and a dictionary of values, and context as an extra one.

There is nothing like hardcoding in the mentioned files.

Thanks.

Changed in openobject-addons:
status: New → Invalid
Revision history for this message
Corentin Pouhet-Brunerie - http://www.Smile.fr (copou) wrote :

Yes the method write has only 2 args but it's not the issue.
Please get read off the expression "vals=" because when I override this method I have to name my attribute "vals" and not "values" for instance. It's not nice.

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Fixed in trunk,
Thanks for reporting.

Changed in openobject-addons:
status: Invalid → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.