Packaging on sales order lines reported as "False"

[Numérigraphe]

Code from the latest v50 branches.
- on the product form, add packaging data to a product, quantity=10
- on the sales order form, enter a new sales order line for that product, quantity=10
=> the field "packaging" in the order line window contains "False" instead of the chosen packaging.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Numérigraphe,

There is no such problem, 'False' value is displayed on packaging just due to you have not entered any value for EAN.

The Name of the package is considered from EAN.

Thank You.

[Numérigraphe (numerigraphe)]

Then I guess the EAN should be mandatory, or the name should revert to some other field if the EAN is empty, or maybe default to "Unnamed packaging".
Anyway it's just wrong for a name to be "False".

[Jay Vora (Serpent Consulting Services) (jayvora)]

Fixed in revision 2311(trunk).

Thanks.

[Numérigraphe (numerigraphe)]

Thank you.

[Numérigraphe (numerigraphe)]

Seems not to be completely fixed, as reported by Ana Juaristi Olalde in bug 404012 :

"This is a minor bug, not critical at all...

Sales order line, when you select a packaging for the product, the name shown on form is "False". Packaging is well assigned to line, but it's not shown correctly on form."

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Lionel,

Kindly read the comment no. 3. It has been fixed in trunk version, as it cannot be considered as a bug/flow-stopping issue.

Thank you.

[Numérigraphe (numerigraphe)]

>It has been fixed in trunk version, as it cannot be considered as a bug/flow-stopping issue.
Ok sorry didn't notice. I'll get the diff and patch my local branches

> Fixed in revision 2311(trunk).
Unfortunately there is no such revision on the trunk addons, the latest is 2310 this morning

[Numérigraphe (numerigraphe)]

I think here's the patch applied by Jay to the trunk on revision <email address hidden>.
Anna can you give it a try please?