error on the init of report_timesheet

[phil]

Hi,

This morning I make a bzr pul to get the last revision of the V5.
When I launch the server with the option update=all on my database.
I got the following message:

[Mon Dec 22 09:05:44 2008] INFO:init:module report_timesheet: registering objects
[Mon Dec 22 09:05:44 2008] INFO:init:module report_timesheet loading objects
[Mon Dec 22 09:05:44 2008] INFO:init:module report_timesheet: creating or updating database tables
Traceback (most recent call last):
  File "openerp-server.py", line 116, in <module>
    pooler.get_db_and_pool(db, update_module=tools.config['init'] or tools.config['update'])
  File "/home/phil/trunk/server/bin/pooler.py", line 38, in get_db_and_pool
    addons.load_modules(db, force_demo, status, update_module)
  File "/home/phil/trunk/server/bin/addons/__init__.py", line 589, in load_modules
    load_module_graph(cr, graph, status, report=report)
  File "/home/phil/trunk/server/bin/addons/__init__.py", line 480, in load_module_graph
    init_module_objects(cr, m, modules)
  File "/home/phil/trunk/server/bin/addons/__init__.py", line 262, in init_module_objects
    obj.init(cr)
  File "/home/phil/trunk/server/bin/addons/report_timesheet/report_timesheet.py", line 51, in init
    """)
  File "/home/phil/trunk/server/bin/sql_db.py", line 76, in wrapper
    return f(self, *args, **kwargs)
  File "/home/phil/trunk/server/bin/sql_db.py", line 114, in execute
    res = self._obj.execute(query, params)
psycopg2.ProgrammingError: ERREUR: ne peut pas modifier le nombre de colonnes dans la vue

when i check the code of report_timesheet.py, and try to execute to sql code.
I indentified that the problem comes from this order:
 create or replace view report_timesheet_user as (
                select
                    min(l.id) as id,
                    l.date as name,
                    l.user_id,
                    sum(l.unit_amount) as quantity,
                    sum(l.amount) as cost
                from
                    account_analytic_line l
                where
                    user_id is not null
                group by l.date, l.user_id
            )

In fact, it should do a drop view instead of a "replace view" when you add a new column (company_id in this case).

[Emmanuel Thibierge (e-thibierge)]

Hi,
Could you release the fix in the stable too ?

[Emmanuel Thibierge (e-thibierge)]

it's the same on stable and trunk, but there are still failures with the init because you need a :
 tools.sql.drop_view_if_exists(cr, 'report_timesheet_invoice')
on each view before the "create or replace".
I don't if I should leave this comment here or create a new bug ?

[Ferdinand (office-chricar)]

see patch

[Christophe CHAUVET (christophe-chauvet)]

I made patch which fix this bug and prevent others problems when column name changed

[Christophe CHAUVET (christophe-chauvet)]

Fix available

[Fabien (Open ERP) (fp-tinyerp)]

fix applied on branch/5