Too slow import, please rethink usage of transactions
Bug #1271834 reported by
Yajo
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Odoo Addons (MOVED TO GITHUB) |
Confirmed
|
Medium
|
OpenERP R&D Addons Team 1 | ||
Bug Description
When importing thousands of partners from other programs, it can be exasperating.
At least, I have spotted one thing could be done better: Button "Import" should only send a "commit" command.
Now, when pressing "validate", it makes a transaction to test if it can be imported. Then it sends a "rollback". Then when pressing "Import", the process is made again from the begining, but ends in a "commit" instead.
Why not just leave that transaction there after validating and just commit if the user presses import and rollback it if he leaves the page or presses cancel (no cancel button for now, it should be added, maybe as a popup message).
That would reduce easily the time by 50% in all cases.
Revision history for this message
| Sandip Mangukiya (sandip-mangukiya) wrote | #1 |
| Changed in openobject-addons: | |
| assignee: | nobody → OpenERP R&D Addons Team 1 (openerp-dev-addons1) |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
To post a comment you must log in.
Hi Yajo,
You are right. Its should be re-think as make single button which perform both process together (i.e. button name as 'Validate & Import') with slightly change at the end(i.e. here rollback & commit). If we are following more or less same process in both button press(Though only difference of rollback or commit at the end), precious time would be save for all.
Thanks & Regards,
Sandip