Supplier invoice form view shows discount field if enabled in *sale orders* settings

[Leonardo Donelli]

View `account.invoice_supplier_form` displays the field `discount` if the `group_discount_per_so_line` flag is selected in the Sales settings.

That view is related to a purchase order (it's the form view for a purchase order invoice), not a sale order, and therefore should not use that flag.

[Amit Parik (amit-parik)]

Hello,

As per my opinion we have to change the group name. Instead of "Discount on Sale order line " we can use the "Disount on order/Invoice line" would be better option.

Thank you!

[Leonardo Donelli (learts92)]

Then the name wouldn't reflect the functionality, because you only see a discount field in sale orders view when the option is activated, not in purchase orders view. The problem is in only in purchase order *invoice*.

[Amit Parik (amit-parik)]

Ok, we have to remove disount field from invoice_supplier_form and put this field on invoice_form which is for customer invoice.

[Leonardo Donelli (learts92)]

Already present in invoice_form.
Either the author just copy-pasted it and so it got in invoice_supplier_form for mistake; or there is confusion about the role of the flag between the writers of the account module and the writers of the purchases/sales modules.