wrong voucher created from bank statement

[Renato Lima - http://www.akretion.com]

In bank statement, if you try import one journal item in journal with general type, you will receive this message:

"The amount of the voucher must be the same amount as the one on the statement line."

This occurs because if you create one payment using one account journal with general type, the account.statement.from.invoice.lines wizard does not use the right sign, you can see in this code:

            type = 'general'
            ttype = amount < 0 and 'payment' or 'receipt'
            sign = 1
            if line.journal_id.type in ('sale', 'sale_refund'):
                type = 'customer'
                ttype = 'receipt'
            elif line.journal_id.type in ('purchase', 'purhcase_refund'):
                type = 'supplier'
                ttype = 'payment'
                sign = -1

To fix this, the code should be this:

            type = 'general'
            ttype = amount < 0 and 'payment' or 'receipt'
            sign = amount < 0 and -1 or 1
            if line.journal_id.type in ('sale', 'sale_refund'):
                type = 'customer'
                ttype = 'receipt'
            elif line.journal_id.type in ('purchase', 'purhcase_refund'):
                type = 'supplier'
                ttype = 'payment'
                sign = -1

Best regards,

Renato Lima - http://www.akretion.com

[Renato Lima - http://www.akretion.com (renatonlima)]

In addons/7.0 revision #9672

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Hello,

not sure if that's the same bug or not, but it's worth mentioning it looks similar as:
https://bugs.launchpad.net/openobject-addons/+bug/1211202