[trunk/7.0]Issue in suggested recipient functionality

Bug #1248589 reported by Sodexis
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Committed
Low
OpenERP R&D Addons Team 1

Bug Description

In addons/mail/mail_thread.py/_message_add_suggested_recipient method,
The condition for checking already existing partner ID is not correct.

OpenERP Version 7.0

TEST CASE:

 Just for the simulation of this bug , I mentioned this example. In Real-Time, this example situation will never occur.

Create a lead with Customer= Administrator and Salesperson=Administrator. Click on Send a message option for that
document. It will show Administrator (<email address hidden>) twice in To: Followers of this document as suggested recipient. Make sure that the Administrator is not in the follower list.

CURRENT CODE:
if partner and partner in [val[0] for val in result[obj.id]]:

val[0] --gives--> partner_id. So its needs to be checked with partner.id instead of partner object.

CORRECTION:

The code should be
if partner and partner.id in [val[0] for val in result[obj.id]]:

Thanks.

Related branches

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 1 (openerp-dev-addons1)
importance: Undecided → Low
status: New → Confirmed
summary: - Issue in suggested recipient functionality
+ [trunk/7.0]Issue in suggested recipient functionality
Revision history for this message
Dharmraj Zala(OpenERP) (dharmraj.zala-openerp) wrote :

Hello Sodexis,

It has been fix commited in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1248589-dja
Revision ID : <email address hidden>
Revision No : 9020

Thanks,
dja

Changed in openobject-addons:
status: Confirmed → In Progress
Changed in openobject-addons:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.