[extra-addons] product_variant_multi generation bug

[Martin Collins]

eoc-extra-addons/6.1 revno 12
ocb server 6.1 revno 4319
Kubuntu 12.04

If you have more than one variant_dimension_type, when you hit the 'generate' button you only get one variant per variant_dimension_value but you should get the cartesian product of type1.values x type2.values etc.
This is a regression.

Furthermore, after I fixed that I found the variants are sorted by variant_dimension_option.sequence then name. Since in my case those sequences are all zero I get an alphabetical sort which is meaningless and throws off my default_code generation. I guess most people will have zero option sequences.
The sort should be by variant_dimension_type.sequence then variant_dimension_option.sequence then name.

I attach a patch which fixes both issues.

Really the links from values -> options -> types should be named more sensibly.

I also note that when I import variant_dimension_options from CSV all the types are set to the first type which rather screws things up. I haven't looked into the reason for this though.

[Amit Parik (amit-parik)]

Hello Martin,

Thanks for the patch and bug report!

But product_variant_multi is a part of extra addons, which is not maintain by "Tiny" anymore.

On trunk version you can see variant available on official product module. For 6.1 you can propose the merge for this, So OpenERP community can look and accept it.

If you or anyone from the community would like to work on it, please mark the bug as "In progress" and assign it to yourself (or ask us or anyone from OpenERP Drivers to do it for you). In the mean time, we will mark it as "Won't fix" to indicate that
no further progress is expected at the moment.

Thank you!

[Martin Collins (mkc-steadfast)]

FAO Mariano @ EOC
Here is the solution for the last problem.

[Mariano Ruiz (marianoruiz)]

Hello Martin, I will be try to test your patch tumorrow, seems to make sense.

[Mariano Ruiz (marianoruiz)]

I've made the merge with the ~mkc-steadfast patch, but now I cannot change the status of the bug. Maybe because ~amit-parik change to "Won't Fix", please Amit, can you change to "Fix Released" status?