Duplicate onchange partner_id methods in crm.lead

[Karel Marissens]

I noticed that in crm.lead, there are 2 onchange methods for partner_id:
- on_change_partner
- onchange_partner_id (defined in base_stage)

The first one is called when changing the partner_id in the lead form. The second one when changing the partner_id in the opportunity form. The methods seem to be almost identical, except that the second one does an address_get for 'contact'.

Is there any reason why the behavior when changing a partner_id is different between a lead and an opportunity?
And why is there an onchange_partner_id method in base_stage? It has nothing to do with stages...

Openerp version: 7.0-20130728-231025

[Foram Katharotiya (OpenERP) (fka-openerp)]

Hello,

  - It has been Fixed in this branch https://code.launchpad.net/~openerp-dev/openobject-addons/7.0-opw-596392-fka.
    revno: 9359
    revid: <email address hidden>

  -It will be available in 7.0 soon.

Thanks,
FKA

[Thibault Delavallée (OpenERP) (tde-openerp)]

Hello,

In 7.0 we won't fix something about duplicate code. This is not considered as a bug. In trunk the whole base_status module has been removed, and all related methods quite refactored. This bug is therefore not valid anymore in trunk.