bug l10n_be_coda: creation of bank account because the matching is wrong
Bug #1206609 reported by
Houssine
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Odoo Addons (MOVED TO GITHUB) |
Fix Committed
|
Low
|
OpenERP Publisher's Warranty Team | |||
OpenERP Community Backports (Addons) | Status tracked in 7.0 | |||||
7.0 |
Fix Committed
|
Low
|
Unassigned |
Bug Description
Hi,
Here we have a little bug concerning creation of unnecessary bank account on partner the following code at line 44
make a wrong matching cause it doens't take into account the difference between to format of bank account number. In fact, the account number from the coda come totally stripped from space charachter while the one of the patner is iban format for example BEXX XXXX XXXX XXXX.
Applying the given patch should solve this problem.
Related branches
lp:~openerp-dev/openobject-addons/7.0-opw-596039-rha
Approved
for merging
into
lp:openobject-addons/7.0
- Martin Trigaux (OpenERP) (community): Disapprove
- Naresh(OpenERP) (community): Approve
- Houssine (community): Approve (reviewed and tested)
-
Diff: 17 lines (+5/-2)1 file modifiedl10n_be_coda/l10n_be_coda.py (+5/-2)
Changed in openobject-addons: | |
assignee: | nobody → OpenERP Publisher's Warranty Team (openerp-opw) |
tags: | added: maintenance |
Changed in openobject-addons: | |
status: | New → Confirmed |
importance: | Undecided → Low |
Changed in openobject-addons: | |
status: | Confirmed → In Progress |
Changed in ocb-addons: | |
status: | New → Fix Committed |
importance: | Undecided → Low |
To post a comment you must log in.
replace the line 44 by this code. Sorry I'm getting the branch and it taking too long so this is all I can provide for now.
cr.execute("select id from res_partner_bank where replace( replace( acc_number, ' ',''),'-','') = %s",(str( data['coda_ account_ number' ]),))
acc_ number_ ids = self.pool. get('res. partner. bank'). search( cr, uid, [('id', 'in', ids)])
ids = [id[0] for id in cr.fetchall()]
# Filter bank accounts which are not allowed