[7.0] 'unreconcile entries' from 'account.move.reconcile' raises exception

[Lorenzo Battistini]

openobject-addons revno 9309

steps:

 - create a new invoice and pay it
 - go to 'payments' tab and open the journal item
 - go to 'Reconcile' field and open it
 - run 'unreconcile entries' wizard

get

Client Traceback (most recent call last):
  File "/home/elbati/workspace/openerp/7.0/web/addons/web/http.py", line 204, in dispatch
    response["result"] = method(self, **self.params)
  File "/home/elbati/workspace/openerp/7.0/web/addons/web/controllers/main.py", line 1128, in call_kw
    return self._call_kw(req, model, method, args, kwargs)
  File "/home/elbati/workspace/openerp/7.0/web/addons/web/controllers/main.py", line 1112, in _call_kw
    names = dict(req.session.model(model).name_get(args[0], **kwargs))
  File "/home/elbati/workspace/openerp/7.0/web/addons/web/session.py", line 42, in proxy
    result = self.proxy.execute_kw(self.session._db, self.session._uid, self.session._password, self.model, method, args, kw)
  File "/home/elbati/workspace/openerp/7.0/web/addons/web/session.py", line 30, in proxy_method
    result = self.session.send(self.service_name, method, *args)
  File "/home/elbati/workspace/openerp/7.0/web/addons/web/session.py", line 103, in send
    raise xmlrpclib.Fault(openerp.tools.ustr(e), formatted_info)

Server Traceback (most recent call last):
  File "/home/elbati/workspace/openerp/7.0/web/addons/web/session.py", line 89, in send
    return openerp.netsvc.dispatch_rpc(service_name, method, args)
  File "/home/elbati/workspace/openerp/7.0/server/openerp/netsvc.py", line 292, in dispatch_rpc
    result = ExportService.getService(service_name).dispatch(method, params)
  File "/home/elbati/workspace/openerp/7.0/server/openerp/service/web_services.py", line 626, in dispatch
    res = fn(db, uid, *params)
  File "/home/elbati/workspace/openerp/7.0/server/openerp/osv/osv.py", line 188, in execute_kw
    return self.execute(db, uid, obj, method, *args, **kw or {})
  File "/home/elbati/workspace/openerp/7.0/server/openerp/osv/osv.py", line 131, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/home/elbati/workspace/openerp/7.0/server/openerp/osv/osv.py", line 197, in execute
    res = self.execute_cr(cr, uid, obj, method, *args, **kw)
  File "/home/elbati/workspace/openerp/7.0/server/openerp/osv/osv.py", line 185, in execute_cr
    return getattr(object, method)(cr, uid, *args, **kw)
  File "/home/elbati/workspace/openerp/7.0/addons/account/account.py", line 1726, in name_get
    result.append((r.id,r.name))
  File "/home/elbati/workspace/openerp/7.0/server/openerp/osv/orm.py", line 486, in __getattr__
    raise AttributeError(e)
AttributeError: 'Field name not found in browse_record(account.move.reconcile, 4)'

Notwithstanding this, journal items are actually unreconciled

[Asgardinho (felipereyesazul)]

any update, details, fix or workaround about this bug?

creating the name field in the object solves anything? is a good or bad idea?

[Michael Karrer (michaelkarrer81)]

Bug with high priority open for more than 7 months without a bigfix or any update does not seem very promising... It is nice to have new Features in OpenERP but i would strongly encourage everyone to start make the current version stable!

[Lorenzo Battistini (elbati)]

On 02/05/2014 06:22 PM, Michael Karrer wrote:
> Bug with high priority open for more than 7 months without a bigfix or
> any update does not seem very promising... It is nice to have new
> Features in OpenERP but i would strongly encourage everyone to start
> make the current version stable!

It seems that nobody reported it with an OEE contract

[Ravi Gohil (OpenERP) (rgo-openerp)]

Hi,

This bug should not be set to "High" priority as it doesn't block anything or it is not breaking the flow. I mean, the traceback is caused after the unreconciliation process is completed, that is, the entries will be deleted once clicked on the "Unreconcile" button in the opened wizard, the problem is caused as the system tries to read the deleted record at the time of closing the wizard and due to the traceback, it ended presenting the deleted record to the user(which misleads end users as if the record isn't deleted).

For the information, the "Unreconcile Entries" wizard here just perform the unlink operation(for account.move.reconcile object records), so alternate option to this would be simply deletion of the entries from "More" drop down.

The only intention of the wizard here is to show the warning("If you unreconcile transactions, you must also verify all the actions that are linked to those transactions because they will not be disable") when a user tries to unreconcile the entries.

This is a bug for sure but a low priority, hence changing it.

About the fix, we are working on it and we will propose a fix soon.

Thanks.

[Denis Durepos (djdurepos)]

We have the same issue: unable to cancel a supplier payment voucher because clicking "Unreconcile" yields the traceback. However, I disagree that it does not affect the flow as it prevents cancellation of the voucher. The reconciliation remains intact after dismissal of the error and the voucher can only be unreconciled (cancelled) using the following workaround (in case this helps anyone ;) ):

1. Go to the "Journal Items" tab on the voucher;
2. Click a line with a reconcile ID;
3. Follow the link to the reconciliation by clicking on the reconcile ID (close the overlaying window - this is incidentally maybe not a bug, but a definite usability issue);
4. Use More>Delete to delete the reconciliation;
5. Return to the voucher (using breadcrumbs or whatever your favorite method is); and
6. Click "Unreconcile" and proceed as intended.

For what its worth, we are an OpenERP Enterprise customer and based on OpenERP's current track record, 7 months seems like a perfectly normal time frame to have completely ignored a crippling bug all the while being perfectly content to collect our money for "unlimited bug fixes". So far, the only unlimited part is the time it takes to resolve issues.

Anyhow, hope this helps someone out of a jam.

[Ravi Gohil (OpenERP) (rgo-openerp)]

Hello Denis,

I suppose you are not affected with the issue mentioned in this bug as this bug was caused when the user tries unreconcile the entries from 'account.move.reconcile' object.

You mentioned that you faced this issue when canceling the voucher, this issue is different than this one and was fixed in github v7 branch by the commit https://github.com/odoo/odoo/commit/8f0392b49099eaca6f4c5cdd0931da0821d73865. In this case, the traceback would be slightly different than the mentioned in this bug, something like below,

  File "/opt/openerp/server/openerp/addons/account_voucher/account_voucher.py", line 963, in cancel_voucher
    reconcile_pool.unlink(cr, uid, [line.reconcile_id.id])
  File "/opt/openerp/server/openerp/addons/account/account.py", line 1649, in unlink
    if move_rec.opening_reconciliation:
  File "/opt/openerp/server/openerp/osv/orm.py", line 504, in __getattr__
    raise AttributeError(e)
AttributeError: 'Field opening_reconciliation not found in browse_record(account.move.reconcile, 4458)'

For the information, a fix was merged for this usability bug as well by mean of PR https://github.com/odoo/odoo/pull/565. So, I am changing the status of this bug to Fix Release.

Would you double check it and let me know if I missed something.

Thanks.