hr_timesheet_sheet's workflow should use methods

[Holger Brunn (Therp)]

I find myself having to work around the workflow activities directly writing the state every now and then.

It would be so much more convenient if they called some dedicated method that we can simply override afterwards.

[Olivier Dony (Odoo) (odo-openerp)]

In trunk all workflow signals are now routed through Model.signal_xxx() methods that you can override as you want, so I think we can consider this wishlist implemented without needing any extra code in hr_timesheet_sheet itself:
   https://doc.openerp.com/trunk/server/orm-methods/#orm-workflows

Moving the code of the workflow activities into Python methods would also reduce the flexibility of the workflows (the fact that they can be customized to some extent without needing to write a module), so it's better to keep the best of both world, I think.

[Holger Brunn (Therp) (hbrunn)]

Thanks, this is a great improvement!

Any chance to have the proposal merged in 7.0?

[Nhomar - Vauxoo (nhomar)]

Hello.

IMHO if and only IF the v8 dont change again the crazy thing of the Look and Feel for end users, IMHO it is more secure, wait for the update.

I just have 1 doubt Oliver.

This new feature will be backguard compatible?

It means, i can use my modules that change workflow as i used to do them, and migrate to the new structure progressively?

Regards.

[Fabien (Open ERP) (fp-tinyerp)]

@nhomar; yes, it's compatible

@holger; no, it's not our policy to change stable versions, we only apply fixes on stable version (we prefer not to take the risk of a regression in a stable version)