hr_timesheet_sheet's workflow should use methods
Bug #1190022 reported by
Holger Brunn (Therp)
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Odoo Addons (MOVED TO GITHUB) |
Fix Released
|
Wishlist
|
OpenERP R&D Addons Team 3 |
Bug Description
I find myself having to work around the workflow activities directly writing the state every now and then.
It would be so much more convenient if they called some dedicated method that we can simply override afterwards.
Related branches
lp:~therp-nl/openobject-addons/lp1190022
Rejected
for merging
into
lp:openobject-addons
- Olivier Dony (Odoo): Disapprove
-
Diff: 60 lines (+20/-4)2 files modifiedhr_timesheet_sheet/hr_timesheet_sheet.py (+16/-0)
hr_timesheet_sheet/hr_timesheet_workflow.xml (+4/-4)
lp:~hbrunn/ocb-addons/lp1190022
Rejected
for merging
into
lp:ocb-addons/6.1
- Holger Brunn (Therp): Disapprove
-
Diff: 60 lines (+20/-4)2 files modifiedhr_timesheet_sheet/hr_timesheet_sheet.py (+16/-0)
hr_timesheet_sheet/hr_timesheet_workflow.xml (+4/-4)
Changed in openobject-addons: | |
assignee: | nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3) |
importance: | Undecided → Wishlist |
status: | New → Confirmed |
To post a comment you must log in.
In trunk all workflow signals are now routed through Model.signal_xxx() methods that you can override as you want, so I think we can consider this wishlist implemented without needing any extra code in hr_timesheet_sheet itself: /doc.openerp. com/trunk/ server/ orm-methods/ #orm-workflows
https:/
Moving the code of the workflow activities into Python methods would also reduce the flexibility of the workflows (the fact that they can be customized to some extent without needing to write a module), so it's better to keep the best of both world, I think.