[7.0] Google authentication failing

Bug #1118151 reported by Javier Fuentes
36
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Medium
OpenERP's Framework R&D

Bug Description

I am trying to get the google-based authentication working. When signing in with google credentials I keep getting an "Authentication error" message.

Taking a look at the log, I have found the following error:

2013-02-06 21:16:33,653 10586 ERROR ? openerp.addons.auth_oauth.controllers.main: OAuth2: %d format: a number is required, not str
Traceback (most recent call last):
  File "/opt/openerp-codeback/server/openerp/addons/auth_oauth/controllers/main.py", line 63, in signin
    credentials = u.auth_oauth(cr, SUPERUSER_ID, provider, kw, context=context)
  File "/opt/openerp-codeback/server/openerp/addons/auth_oauth/res_users.py", line 79, in auth_oauth
    login = self._auth_oauth_signin(cr, uid, provider, validation, params, context=context)
  File "/opt/openerp-codeback/server/openerp/addons/auth_oauth_signup/res_users.py", line 42, in _auth_oauth_signin
    email = validation.get('email', 'provider_%d_user_%d' % (provider, oauth_uid))
TypeError: %d format: a number is required, not str

I am working on ubuntu 12.10 and OpenERP version "7.0-20130108-001542"

Thanks!

summary: - Google authentication failing
+ [7.0] Google authentication failing
Revision history for this message
Jignesh Rathod(OpenERP) (jir-openerp) wrote :
Revision history for this message
Jignesh Rathod(OpenERP) (jir-openerp) wrote :

Hello ,

I have checked this issue with latest trunk but I did not face any problem with google
authentication , I can successfully login with openid , So would you please check this again
with latest updated code and provide info regarding this issue.

OpenID url :
https://www.google.com/accounts/o8/id

OpenID email :
         Your email address.

I have attached video for your more reference [ auth_openid.ogv ].

Thanks and waiting for reply!

Changed in openobject-addons:
status: New → Incomplete
Revision history for this message
Nicolas JEUDY (njeudy) wrote :
Revision history for this message
Javier Fuentes (javier-codeback) wrote :

Thank you for your quick answer Jignesh.

We are not using OpenID, we are trying to access using the "Log in with google" feature. As Nicolas pointed out, it is probably a problem with oauth2.

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Hi,

There was indeed an issue with the way our OAuth modules expected the User ID from the OAuth provided to be numeric all the time, while Google's IDs are alphanumerical.

This is fixed in the addons 7.0 branch as of revision 8708 (revision-id: <email address hidden>)

Thanks for reporting!

Changed in openobject-addons:
assignee: nobody → OpenERP's Framework R&D (openerp-dev-framework)
importance: Undecided → Medium
milestone: none → 7.0
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.