[trunk/7.0] project_crm : sale_order_id does not appear in the correct location on project.task

[Nicolas JEUDY]

Version: OpenERP 7.0 runbot (and probably others)
How to demonstrate this thanks to a direct bug in runbot:

- launch runbot
- in setting>project, check "allow task delegation"
- In task view, sale_order_id should appear after state located in Extra info page

 code: (project_mrp/project_mrp_view.xml)

       <record id="view_project_mrp_inherit_form2" model="ir.ui.view">
            <field name="name">project.mrp.form.view.inherit</field>
            <field name="model">project.task</field>
            <field name="inherit_id" ref="project.view_task_form2"/>
            <field name="arch" type="xml">
                <field name="state" position="after">
                    <field name="sale_line_id" string="Order Line"/>
                </field>
            </field>
        </record>

but due to the presence of 2 occurrences of "state" labeled fields in the project.task form, inheritance apply only to the first one, which happens to be the wrong. With chance (or bad luck), this bug won't cause exceptions, because the subview happens to support the addition of "sale_line_id". Nevertheless, this causes a silent bug in the replacement of the field. This is what is shown in the video.

project.project_view.xml:

        <field name="arch" type="xml">
                <form string="Project" version="7.0">
                    ....
                    <notebook>
                        ...
                        <page string="Delegation" groups="project.group_delegate_task">
                            ...
                            <field name="child_ids">
                                <tree string="Delegated tasks">
                                    ...
                                    <field name="stage_id"/>
                                    <field name="state" invisible="1"/>
                                    <field name="effective_hours" widget="float_time"/>
                                    ...
                                </tree>
                            </field>
                        </page>
                        <page string="Extra Info" attrs="{'readonly':[('state','=','done')]}">
                            <group col="4">
                                ...
                                <field name="state" invisible="1"/>
                            </group>
                        </page>
                    </notebook>
                    </sheet>
                     ...
                </form>
            </field>

see video

[Nicolas JEUDY (njeudy)]

Use xpath to locate correct state field instead of field name.

[Nicolas JEUDY (njeudy)]

adding video: https://www.youtube.com/watch?v=-ARGty4qYVI

[Hiral Patel (OpenERP) (hip-openerp)]

Hello,

           For trunk it has been Fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1097808-hip
           Revno: 8498
           Revision ID: <email address hidden>

Thanks,
hip

[Hiral Patel (OpenERP) (hip-openerp)]

Hello,

           For 7.0 it has been Fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/7.0-bug-1097808-hip
           Revno: 8561
           Revision ID: <email address hidden>

Thanks,
hip

[Martin Trigaux (OpenERP) (mat-openerp)]

Hello Nicolas,
Thanks for reporting this. We have integrated the change into openerp addons 7.0 at revision 9238 (revision-id: <email address hidden>)
It will be forward ported in trunk soon
Regards