[6.1, 7.0, account_voucher] Wrong amounts with line type set to credit on journal voucher

[Stefan Rijnhart (Opener)]

Steps to reproduce;

- using lp:openobject-addons/trunk revno 8076, install new database and chart of accounts e.g. l10n_nl
- install account_voucher
- set default income and expense accounts of purchase journal to '7002, purchases'
- go to Invoicing -> Journal entries -> Journal vouchers
- create a new entry. Set type to 'purchase', select 'Purchase journal', Choose a partner.
- create a new voucher line. Account is set to 7002 by default. Set amount to €50,-. Set line type to 'Credit'.
- post voucher

Expected results:
One move line debit €50 on the account payable
one move line credit €50 on '7002, purchases'

Observed results:
One move line debit €100 on the account payable
another move line credit €50 on the account payable
one move line credit €50 on '7002, purchases'

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

It's a regression, right?

I mean, we never know may be one day, regressions are given the attention they deserve, so that's why I would advise to do like in every serious company: put the word "regression" in the bug report title. I mean it's just a technical advice just in case...
Thanks for the report.

[Stefan Rijnhart (Opener) (stefan-opener)]

No, it's in 6.1 as well unfortunately

[Mario Arias (the-clone-master)]

Ever since we tried to use account_voucher on 6.0, it has been unusable... specially when using multiple currencies...

Thanks to enapps and their account_voucher_enapps total rewrite, we stopped suffering... ;-)

It is worth a look and try to adjust modules that depend on original account_voucher to work with enapps version...

Regards,
-Mario

[Stefan Rijnhart (Opener) (stefan-opener)]

Well, looking at the Enapps module for vouchers, it does implement part of the necessary refactoring: it only implements (supplier and customer) payment vouchers and does away with sale and purchase vouchers. That way, it does not have to bother with taxes either. I think it is a very good design choice and it opens up the way for a dedicated module for sale and purchase vouchers.

We need a similar approach in standard OpenERP but it will lead to API changes.

[Josse Colpaert (OpenERP) (jco-openerp)]

I reproduced the bug also, but we think the menuitem "Journal Vouchers" under Journal Entries should disappear as it is not relevant. You could do the same with Sales Receipt or by manually entering the journal entries. These functionalities don't have these bugs.

[Stefan Rijnhart (Opener) (stefan-opener)]

Well, that is a valid workaround but I think having code that undocumentedly makes assumptions about the view that is being used is a bit of a timebomb in the core of your financial system. Having that said, the real problem is in the design of vouchers and using the same model for payment vouchers as well as sale and purchase vouchers and my patch does not solve that either.