Activity log for bug #1073455

Date Who What changed Old value New value Message
2012-10-31 07:46:54 Rudolf Schnapka bug added bug
2012-10-31 07:46:54 Rudolf Schnapka attachment added file "mrp/report/price.py" applied XML-conversion to all textual entities, translations, xml-format https://bugs.launchpad.net/bugs/1073455/+attachment/3419530/+files/price.py
2012-10-31 07:47:40 Rudolf Schnapka description in module mrp -> product (branch 6.1) when creating "Product cost structure" report, in a few situations the created XML causes the report-generation to cause traceback. The problem arised specifically when i. e. the company name contains special characters like the ampersand "&". Method create_rml() expects correct XML and in this case the ampersand in the company name will make the rml-creation fail. Solution is: add method to_xml() to the company.name line (near code-line 116) ... this also would apply to all other textual "names" like product name and if someone would really use special chars like the ampersand in UOM the "uom.name" should also be wrapped "to_xml". In addition the language-translation-method _() should be applied for all instances of names (company, product, uom...) I have applied these changes to my local branch file "mrp/report/price.py" (working tree) but I am not sure about the process of committing this file... assistance on how to commit properly would be needed for me to share this code. thank you! ...and hope it helps. P. S. In summary this issue should then be solved when applied. The attached file also includes changes I made to the format of the generated XML. The file should be generally acceptable and as such can be exchanged for the currently used one in the 6.1-branch (possibly also in trunk). in module mrp -> product -> report (branch 6.1) when creating "Product cost structure" report, in a few situations the created XML causes the report-generation to cause traceback. The problem arised specifically when i. e. the company name contains special characters like the ampersand "&". Method create_rml() expects correct XML and in this case the ampersand in the company name will make the rml-creation fail. Solution is: add method to_xml() to the company.name line (near code-line 116) ... this also would apply to all other textual "names" like product name and if someone would really use special chars like the ampersand in UOM the "uom.name" should also be wrapped "to_xml". In addition the language-translation-method _() should be applied for all instances of names (company, product, uom...) I have applied these changes to my local branch file "mrp/report/price.py" (working tree) but I am not sure about the process of committing this file... assistance on how to commit properly would be needed for me to share this code. thank you! ...and hope it helps. P. S. In summary this issue should then be solved when applied. The attached file also includes changes I made to the format of the generated XML. The file should be generally acceptable and as such can be exchanged for the currently used one in the 6.1-branch (possibly also in trunk).
2012-10-31 10:42:39 Jignesh Rathod(OpenERP) openobject-addons: importance Undecided Medium
2012-10-31 10:42:39 Jignesh Rathod(OpenERP) openobject-addons: status New Confirmed
2012-10-31 10:42:39 Jignesh Rathod(OpenERP) openobject-addons: assignee OpenERP R&D Addons Team 2 (openerp-dev-addons2)
2012-11-12 18:58:10 Rudolf Schnapka attachment added patch mrp-report-price.py to deal correctly with non-XML inputs (branch 6.1) https://bugs.launchpad.net/openobject-addons/+bug/1073455/+attachment/3431527/+files/mrp.report.price.py.patch
2012-12-04 14:05:32 Arnaud Pineux (OpenERP) openobject-addons: status Confirmed In Progress
2012-12-04 14:18:16 Launchpad Janitor branch linked lp:~openerp-dev/openobject-addons/trunk-bug-1073455-api
2012-12-04 14:37:34 Arnaud Pineux (OpenERP) openobject-addons: status In Progress Fix Committed