Comment 3 for bug 1066127

I am a bit suprised by your analysis of the code, because you consider the code of the copy() function of stock.picking only when it is called from stock/wizard/stock_return_picking.py, but not when called by other parts of the code of the addons or extra-addons modules.

I know that when the copy() function is called from stock/wizard/stock_return_picking.py, the code inside the "if" will never be executed... that's what I want, because the "default" dict has an "invoice_state" key ! But, when the copy() function is called from other functions (that may belong to other modules), that code may be usefull... so I am surprised by your merge proposal in which you remove the code !

So I think that my patch is valid and is a good solution to the problem.