Odoo Addons (MOVED TO GITHUB)

French localization adds SIRET to the wrong object

Bug #1042324 reported by Numérigraphe
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Account - Financial Tools
Fix Released
Undecided
Unassigned
Odoo Addons (MOVED TO GITHUB)
Opinion
Undecided
Unassigned

Bug Description

In the trunk, l10n_fr was recently improved and introduced new fields to record the SIRET number (official id number) and APE code of companies.
Unfortunately, this was added to the wrong object : res.company.

This makes it only useful for the user's company, but French users very often use these pieces of information to assert the legal existence of their partners too.
So it should be defined in res.partner instead.

Lionel Sausin

Related branches

lp:~camptocamp/openobject-addons/7.0-l10n-fr-siret
Numérigraphe (community): Disapprove
OpenERP French Localization: Pending requested
OpenERP Core Team: Pending requested
Diff: 422 lines (+313/-23)
9 files modified
l10n_fr/__openerp__.py (+4/-1)
l10n_fr/l10n_fr_view.xml (+0/-21)
l10n_fr_rib/__openerp__.py (+1/-1)
l10n_fr_siret/__init__.py (+25/-0)
l10n_fr_siret/__openerp__.py (+45/-0)
l10n_fr_siret/i18n/fr.po (+57/-0)
l10n_fr_siret/i18n/l10n_fr_siret.po (+57/-0)
l10n_fr_siret/partner.py (+99/-0)
l10n_fr_siret/partner_view.xml (+25/-0)
lp:~camptocamp/account-financial-tools/7.0-add_l10n_fr_siret
Numérigraphe (community): Approve
Account Core Editors: Pending requested
Diff: 339 lines (+308/-0)
6 files modified
l10n_fr_siret/__init__.py (+25/-0)
l10n_fr_siret/__openerp__.py (+45/-0)
l10n_fr_siret/i18n/fr.po (+57/-0)
l10n_fr_siret/i18n/l10n_fr_siret.po (+57/-0)
l10n_fr_siret/partner.py (+99/-0)
l10n_fr_siret/partner_view.xml (+25/-0)
lp:~numerigraphe-team/openobject-addons/trunk-l10n-fr-siret
Rejected for merging into lp:openobject-addons
Lionel Sausin - Initiatives/Numérigraphe (community): Disapprove
Alexandre Fayolle - camptocamp: Pending requested
OpenERP French Localization: Pending requested
OpenERP Core Team: Pending requested
Christophe CRIER: Pending (functional) requested
risto3: Pending (functional) requested
Diff: 476 lines (+341/-32) (has conflicts)
12 files modified
l10n_fr/__openerp__.py (+4/-2)
l10n_fr/l10n_fr.py (+3/-0)
l10n_fr/l10n_fr_view.xml (+0/-21)
l10n_fr_rib/__openerp__.py (+1/-0)
l10n_fr_siret/__init__.py (+25/-0)
l10n_fr_siret/__openerp__.py (+50/-0)
l10n_fr_siret/i18n/fr.po (+57/-0)
l10n_fr_siret/i18n/l10n_fr_siret.po (+57/-0)
l10n_fr_siret/partner.py (+98/-0)
l10n_fr_siret/partner_view.xml (+25/-0)
product/product.py (+19/-8)
stock/stock.py (+2/-1)
Revision history for this message
Numérigraphe (numerigraphe) wrote :

Confirming based on comments from risto3 on https://answers.launchpad.net/openobject-server/+question/205409

Changed in openobject-addons:
status: New → Confirmed
status: Confirmed → Fix Committed
Revision history for this message
Numérigraphe (numerigraphe) wrote :

I've updated lp:~numerigraphe/openobject-addons/trunk-l10n-fr-siret to include this bug.
Lionel

Amit Parik (amit-parik)
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
Arnaud Pineux (OpenERP) (api-openerp)
Changed in openobject-addons:
status: Fix Committed → In Progress
status: In Progress → Fix Committed
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

Hello,

I've just submitted an updated version of Numérigraphe's branch which merges cleanly on top of the 7.0 branch.

Feedback (or merge!) are welcome.

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

I've submitted a MP to include this in a community supported module. The MP is available here: https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-add_l10n_fr_siret/+merge/146661

Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)
Changed in ocb-addons:
status: New → Fix Released
no longer affects: ocb-addons
Changed in account-financial-tools:
status: New → Fix Released
Revision history for this message
Numérigraphe (numerigraphe) wrote :

I've updated the community module to redirect the SIRET from company to the related partner.
So we've worked around the problem, no need to patch the core addons.

Changed in openobject-addons:
assignee: OpenERP R&D Addons Team 3 (openerp-dev-addons3) → nobody
status: Fix Committed → Opinion
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.