mrp confirm creates consumed products lines twice

[Ferdinand]

fresh install of mrp module

using [CPU_GEN] Regular processor config

Confirm

test_mrp=# select id,product_id,product_qty,state,date,production_id,picking_id,location_id,location_dest_id from stock_move order by id desc limit 9;
 id | product_id | product_qty | state | date | production_id | picking_id | location_id | location_dest_id
-----+------------+-------------+---------+---------------------+---------------+------------+-------------+------------------
 110 | 18 | 5.000 | waiting | 2012-07-26 20:13:47 | | 16 | 19 | 19
 109 | 18 | 5.000 | waiting | 2012-07-26 20:13:47 | | | 19 | 7
 108 | 15 | 5.000 | waiting | 2012-07-26 20:13:47 | | 16 | 19 | 19
 107 | 15 | 5.000 | waiting | 2012-07-26 20:13:47 | | | 19 | 7
 106 | 8 | 5.000 | waiting | 2012-07-26 20:13:47 | | 16 | 19 | 19
 105 | 8 | 5.000 | waiting | 2012-07-26 20:13:47 | | | 19 | 7
 104 | 10 | 5.000 | waiting | 2012-07-26 20:13:47 | | 16 | 19 | 19
 103 | 10 | 5.000 | waiting | 2012-07-26 20:13:47 | | | 19 | 7
 102 | 17 | 5.000 | waiting | 2012-07-26 20:13:47 | 9 | | 7 | 18
(9 rows)

after Force availablility it looks like - please not the resources with picking which are already done

test_mrp=# select id,product_id,product_qty,state,date,production_id,picking_id,location_id,location_dest_id from stock_move order by id desc limit 9;
 id | product_id | product_qty | state | date | production_id | picking_id | location_id | location_dest_id
-----+------------+-------------+----------+---------------------+---------------+------------+-------------+------------------
 110 | 18 | 5.000 | done | 2012-07-26 20:15:45 | | 16 | 19 | 19
 109 | 18 | 5.000 | assigned | 2012-07-26 20:13:47 | | | 19 | 7
 108 | 15 | 5.000 | done | 2012-07-26 20:15:45 | | 16 | 19 | 19
 107 | 15 | 5.000 | assigned | 2012-07-26 20:13:47 | | | 19 | 7
 106 | 8 | 5.000 | done | 2012-07-26 20:15:45 | | 16 | 19 | 19
 105 | 8 | 5.000 | assigned | 2012-07-26 20:13:47 | | | 19 | 7
 104 | 10 | 5.000 | done | 2012-07-26 20:15:45 | | 16 | 19 | 19
 103 | 10 | 5.000 | assigned | 2012-07-26 20:13:47 | | | 19 | 7
 102 | 17 | 5.000 | waiting | 2012-07-26 20:13:47 | 9 | | 7 | 18
(9 rows)

after cancel of a MO we have canceled and done stock moves which is wrong
I think the associated picking has to be canceled too.
due to the fact that from and to location of the done is identical (ma be only in this example) the compution of stock qty is not affected - the qustion remains - what is the purpose of theses stock moves ?

test_mrp=# select id,product_id,product_qty,state,date,production_id,picking_id,location_id,location_dest_id from stock_move order by id desc limit 9;
 id | product_id | product_qty | state | date | production_id | picking_id | location_id | location_dest_id
-----+------------+-------------+--------+---------------------+---------------+------------+-------------+------------------
 110 | 18 | 5.000 | done | 2012-07-26 20:15:45 | | 16 | 19 | 19
 109 | 18 | 5.000 | cancel | 2012-07-26 20:13:47 | | | 19 | 7
 108 | 15 | 5.000 | done | 2012-07-26 20:15:45 | | 16 | 19 | 19
 107 | 15 | 5.000 | cancel | 2012-07-26 20:13:47 | | | 19 | 7
 106 | 8 | 5.000 | done | 2012-07-26 20:15:45 | | 16 | 19 | 19
 105 | 8 | 5.000 | cancel | 2012-07-26 20:13:47 | | | 19 | 7
 104 | 10 | 5.000 | done | 2012-07-26 20:15:45 | | 16 | 19 | 19
 103 | 10 | 5.000 | cancel | 2012-07-26 20:13:47 | | | 19 | 7
 102 | 17 | 5.000 | cancel | 2012-07-26 20:13:47 | 9 | | 7 | 18
(9 rows)

[Ferdinand (office-chricar)]

thanks for looking into this

a patch for 6.1 would be appreciated as this bug obviously makes the module unusable