[6.1/trunk] Invalid commitment date in sale_order_dates module

[Yann Papouin]

The commitment date which is the "Date on which delivery of products is to be made" is badly computed as it is get from: min(dates_list) it should be max(dates_list) (I agree that it "could" be min if the picking_policy is set to "direct") :

Consider two sale order lines:

Product A: delay to deliver: 8 days
Product B: delay to deliver: 24 days

The commitment date must obviously be the current date + 24 business days

[Amit Parik (amit-parik)]

Hello Yann.

As per the tool-tip it should be maximum date.

Thanks for the pointing out this.

This issue has been committed on lp:~openerp-dev/openobject-addons/trunk-bug-1007317-amp branch with revno 6858 and rev id <email address hidden>.

It will be merge with trunk soon.

Thanks!

[Fabien (Open ERP) (fp-tinyerp)]

no, the commitment is based on what you promise to your customer. it's normal to take the min(), otherwise you do not respect the commitment for some products.

[Yann Papouin (yann-papouin)]

no, that's depends on the picking policy:

In [direct]: deliver each product as soon as possible -> ok in that case it could be min()
In [one]: deliver all product at once -> in that case it must be max() as we will have to wait for each product to be ready before deliver.

[Lionel Sausin - Numérigraphe (lionel-sausin)]

I agree with Yann's suggestion.