Allow different scripture notations

Bug #802166 reported by Andreas Preikschat
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Released
Wishlist
Meinert Jordan
Documentation
Fix Committed
Medium
Tomas Groth

Bug Description

Hello,

xubuntu 11.04, r1657

Currently the user is forced to use the English notation for bibles: 1. Mose 1:1-2 (which is Genesis 1:1-2)

But the German notation is "1. Mose 1, 1-2". We should not force to use the English notation, instead the local notation should be used.
I do not know if Germany is an exception with the notation. If Germany is an exception we can hard code it otherwise a translation file based solution would be preferred (if possible. The regex might not allow use to do this).

NOTE: in openlp/core/plugins/bibles/lib/__init__ a German regex is commented in the code.

Cheers

Related branches

Revision history for this message
Meinert Jordan (m2j) wrote :

At least the keyword "end" depends strongly on the language.

I would prefere have both possibilities:
- Syntax according to the envoinment language (a simple translate() statement is fine see: lp:~m2j/openlp/i18n/openlp/plugins/bibles/lib/__init__.py)
- Syntax configurable in the bibles configuration with edit lines using a validator with apropriate rexexp.

This is just a comment if s/o feels to implement it. ATM there is feature freeze, so won't look at this before 2012.

Meinert Jordan (m2j)
Changed in openlp:
assignee: nobody → Meinert Jordan (m2j)
status: New → Fix Committed
Revision history for this message
Andreas Preikschat (googol-deactivatedaccount) wrote :

The documentation needs to be updated: http://manual.openlp.org/configure.html?#bibles
- Screenshot
- Explain new feature

Changed in openlp:
milestone: none → 1.9.9
Revision history for this message
Meinert Jordan (m2j) wrote :

Some more informations for documentation writers:
The use of the settings are explained in tooltips in the settings tab.
Basically it says:
- You can customize the separators and give multiple alternatives separated by a vertical bar “|”.
- In case you give alternatives the first value will be default and used when displaying a reference string (e.g. on the bibles slides).
- Keep in mind, that most propably it makes no sence to use the same value for different separators.
- If the check is not ticked, then the GUI language dependent default will be used.

In http://manual.openlp.org/mediamanager.html#bibles there needs to be some additional hints for this:
- Remind users, that the reference format will be language dependent.
- They will see some valid scripture reference formats in the error dialog when using a wrong one.
- The listed scripture references are not anymore all supported formats but rather some valid ones beyond much others. (I guess the list is still enough, but in case documentation writers like to see a complete, comprehensible explanation: http://docs.openlp.org/plugins/bibles.html#openlp.plugins.bibles.lib.parse_reference)

Changed in openlp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.