OpenSong importer crashes at v1a verse markup

Bug #953240 reported by mahfiaz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Released
Undecided
Meinert Jordan

Bug Description

Importing the following OpenSong song fails:
[V1a]
Suur on su ustavus
[V1b]
suur on su ustavus

Such markup is totally valid for OpenSong:
http://sourceforge.net/tracker/?func=detail&aid=3459158&group_id=108754&atid=651379

The original report is at:
http://support.openlp.org/issues/347

Traceback (most recent call last):
  File "/home/mattias/Arendus/OpenLP/openlp/openlp/core/ui/wizard.py", line 191, in onCurrentIdChanged
    self.performWizard()
  File "/home/mattias/Arendus/OpenLP/openlp/openlp/plugins/songs/forms/songimportform.py", line 771, in performWizard
    importer.doImport()
  File "/home/mattias/Arendus/OpenLP/openlp/openlp/plugins/songs/lib/opensongimport.py", line 116, in doImport
    self.doImportFile(song_file)
  File "/home/mattias/Arendus/OpenLP/openlp/openlp/plugins/songs/lib/opensongimport.py", line 226, in doImportFile
    self.addVerse(lines, verse_def)
  File "/home/mattias/Arendus/OpenLP/openlp/openlp/plugins/songs/lib/songimport.py", line 256, in addVerse
    elif int(verse_def[1:]) > self.verseCounts[verse_def[0]]:
ValueError: invalid literal for int() with base 10: '1a'

Related branches

Revision history for this message
Jonathan Corwin (j-corwin) wrote :
Changed in openlp:
status: New → Confirmed
Revision history for this message
Phill (phill-ridout) wrote :
Meinert Jordan (m2j)
Changed in openlp:
assignee: nobody → Meinert Jordan (m2j)
status: Confirmed → Fix Committed
Revision history for this message
Jonathan Corwin (j-corwin) wrote :

Wondering who linked this to related branch lp:openlp?
If we do link, don't we normally link to the branch it was fixed in e.g. lp:~m2j/openlp/bug-953240 ?

Changed in openlp:
status: Fix Committed → Fix Released
milestone: none → 1.9.10
Revision history for this message
Phill (phill-ridout) wrote :

I've just spotted this bug. Has this made it in to trunk? If so, I still get these issues! My branch https://code.launchpad.net/~phill-ridout/openlp/opensong_fix/+merge/110890 deals with this.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.