Invalid file name characters in song name causes OpenLyrics to crash

[Phill]

http://support.openlp.org/issues/465

Certain invalid file name characters can appear in song names. (in this example a tab, but new line, and others)

This causes the OpenLyrics exporter to crash. These be stripped from the file name. Ideally they would also be caught, and reported as a song error to the user.

Phill

[Jonathan Corwin (j-corwin)]

I managed to enter a tab and newline by copy and pasting them into the song edit title textbox.
So we need to
1. Ensure these characters can't be entered/pasted into the title textbox.
2. Ensure song imports strip them out too
3. Perhaps change the Re-index Songs to strip out any that exist already so people can fix their data.
4. Bullet proof the song export to remove invalid characters. Note it didn't crash for newline or \ / : etc, only for tab.

[Phill (phill-ridout)]

1. I was already working on this for another bug
2, 3 Could probably reuse the same code as 1
4. It didn't crash on new line because I fixed that already (Went in to trunk last saturday)

I'll take a crack at this, not sure if I'll get it in before 1.9.9, so if somebody wants to take this on for 1.9.9 please feel free.

[Phill (phill-ridout)]

Related to: http://support.openlp.org/issues/315