OpenSong importer: wrong verse order
Bug #648263 reported by
Gyuris Gellért
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Released
|
Medium
|
mahfiaz |
Bug Description
It seems to me, the importer only copy the OpenSong verse order, and does not "translate" to OpenLP style.
For example, see the attachment song/screenshot:
- OpenSong verse order was unspecified (but if it is given, it does not matter), so: "V1 B C"
- The imported verse order is: "V1 B1 C1"
- But, should be: "V1 M1 R1"
The sequence refers on no-existing element.
Related branches
lp:~mahfiaz/openlp/opensongfixes
- Raoul Snyman: Approve
- Jon Tibble (community): Approve
- Tim Bentley: Needs Fixing
-
Diff: 1161 lines (+468/-309)9 files modifiedopenlp/core/ui/slidecontroller.py (+8/-7)
openlp/plugins/songs/forms/editsongform.py (+107/-47)
openlp/plugins/songs/forms/editversedialog.py (+14/-14)
openlp/plugins/songs/forms/editverseform.py (+24/-21)
openlp/plugins/songs/lib/__init__.py (+141/-62)
openlp/plugins/songs/lib/mediaitem.py (+36/-11)
openlp/plugins/songs/lib/opensongimport.py (+86/-95)
openlp/plugins/songs/lib/songimport.py (+50/-51)
openlp/plugins/songs/lib/xml.py (+2/-1)
Changed in openlp: | |
milestone: | none → 1.9.4 |
assignee: | nobody → Martin Thompson (mjthompson) |
assignee: | Martin Thompson (mjthompson) → nobody |
assignee: | nobody → Martin Thompson (mjthompson) |
importance: | Undecided → Medium |
Changed in openlp: | |
assignee: | Martin Thompson (mjthompson) → nobody |
tags: | added: opensong-import |
Changed in openlp: | |
assignee: | nobody → Martin Thompson (mjthompson) |
Changed in openlp: | |
milestone: | 1.9.4 → 1.9.5 |
Changed in openlp: | |
assignee: | Martin Thompson (mjthompson) → mahfiaz (mahfiaz) |
status: | New → In Progress |
Changed in openlp: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Thanks Gyuris.
Your opensong file seems (to me) to say V1, B, C *is* the correct order - those are the tags used in there. Where are the M and R coming from?
Is the issue a translation one? Should we be displaying "B"as "M" and "R" as "C"? (By the way, what are M and R short for?)
Sorry, I don't seem to be understanding the problem sufficiently to fix it!