V2892 Service Theme not working
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Committed
|
Medium
|
Tim Bentley |
Bug Description
Windows 10 32 bit
Openlp trunk Version 2892
The Theme drop down in the Service plugin appears to do nothing....I tried changing the setting between the three possibilities, song/service/
To Recreate:
1. in Settings->Theme set Global Theme to 'Blue Burst'
2. Set Theme Level to Song Level
3. select the OK button to exit settings
4. edit a song to have the 'Sea with trees' theme
5. add the same song to the service
6. add another song to the service after verifying it does NOT have a theme associated with the song
7. create a custom slide and use the 'Sea with trees' theme
8. add the custom slide to the Service.
9. set the Theme in the Service to Geo Purple
10. send the Service to the 'Live' screen and watch the themes.
Based on the description of the SONG Level setting I would think the song without a theme associated should display with the 'Geo Purple' theme but it displays with the Blue Burst theme.
Song Level description:
Use the Theme from each song in the database. If a song doesn't have a them associated with it, then use the service's theme. If the service doesn't have a theme, then use the global theme.
Related branches
- Raoul Snyman: Approve
-
Diff: 350 lines (+154/-27)7 files modifiedopenlp/core/display/render.py (+21/-1)
openlp/core/lib/serviceitem.py (+7/-1)
openlp/core/ui/mainwindow.py (+2/-1)
openlp/core/ui/servicemanager.py (+11/-18)
openlp/plugins/presentations/lib/maclocontroller.py (+2/-1)
openlp/plugins/songs/forms/editsongdialog.py (+0/-2)
tests/functional/openlp_core/display/test_render.py (+111/-3)
Changed in openlp: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
assignee: | nobody → Tim Bentley (trb143) |
Changed in openlp: | |
milestone: | none → 2.9.1 |
status: | Confirmed → Fix Committed |
This is still happening on Trunk V2898
Windows 10 32 bit